[jira] [Comment Edited] (IGNITE-429) Implement IgniteStormStreamer to stream data from Apache Storm

["Anton Vinogradov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939618#comment-14939618 ] 

Anton Vinogradov edited comment on IGNITE-429 at 10/1/15 10:18 AM:
-------------------------------------------------------------------

Gianfranco,

Thanks for fixing pull request,

Sorry for delay, but I did not see notifications that you made changes. You sent notification to @anton-vinogradov, but that's not my primary github account.
Next time please update issue, in this case every community member will be informed.

Unfortunately code still not ready to be reviewed.
1) Code contains redundant comments.
for example: // refreshPartitions();
2) Redundant newlines should be removed. At code and imports.
3) Newlines should be added where it necessary:
for example:
Map<?, ?> res = process(tuple);
collector.emit(new Values(res));
4) Some methods have no javadoc.
5) @Override should be located according to Coding Guidelines.
6) Javadoc sentences should be finished with dot.
7) Git conflicts should be resolved, see GridSqlQueryParser.java for details.

Please recheck whole code matches Coding Guidelines and contains only files related to this issue.


was (Author: avinogradov):
Gianfranco,

Thanks for fixing pull request,

Sorry for delay, but I did not see notifications that you made changes. You sent notification to @anton-vinogradov, but that's not my primary github account.
Next time please update issue, in this case every community member will be informed.

Unfortunately code still not ready to be reviewed.
1) Code contains redundant comments.
for example: // refreshPartitions();
2) Redindant newlines should be removed. At code and imports.
3) Newlines should be added where it necessary:
for example:
Map<?, ?> res = process(tuple);
collector.emit(new Values(res));
4) Some methods have no javadoc.
5) @Override should be located according to Coding Guidelines.
6) Javadoc sentences should be finished with dot.
7) Git conflicts should be resolved, see GridSqlQueryParser.java for details.

Please recheck whole code matches Coding Guidelines and contains only files related to this issue.

> Implement IgniteStormStreamer to stream data from Apache Storm
> --------------------------------------------------------------
>
>                 Key: IGNITE-429
>                 URL: https://issues.apache.org/jira/browse/IGNITE-429
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: streaming
>            Reporter: Dmitriy Setrakyan
>            Assignee: Chandresh Pancholi
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under high load. It was previously named {{IgniteDataLoader}}, see ticket IGNITE-394.
> See [Apache Storm|https://storm.apache.org/] for more information.
> We should create {{IgniteStormStreamer}} which will consume tuples from Storm and stream them into Ignite caches. 
> More details to follow, but to the least we should be able to:
> - Convert/Intercept Storm tuples to Ignite data using an optional pluggable converter.
> - Specify the cache name for the Ignite cache to load data into.
> - Specify other flags available on {{IgniteDataStreamer}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)