[kudu-CR] Adds HAS CLMUL to control inclusion of HW carryless multiply

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19011 )

Change subject: Adds HAS_CLMUL to control inclusion of HW carryless multiply
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19011/2/src/kudu/common/columnar_serialization.cc
File src/kudu/common/columnar_serialization.cc:

http://gerrit.cloudera.org:8080/#/c/19011/2/src/kudu/common/columnar_serialization.cc@29
PS2, Line 29: #ifndef HAS_CLMUL
            : #if  defined (__x86_64__)  || defined (_aarch64__)
            : #define HAS_CLMUL
            : #endif
            : #endif
I think this sort of extra macro should be added via $KUDU_HOME/CMakeLists.txt instead of duplicating this logic in every file that has some relevant code.

See add_definitions() $KUDU_HOME/CMakeLists.txt for an example/reference.



-- 
To view, visit http://gerrit.cloudera.org:8080/19011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a4c9dde78530186bf25c1ecb4a0120c93f00fd
Gerrit-Change-Number: 19011
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 17 Jan 2023 02:38:45 +0000
Gerrit-HasComments: Yes