[GitHub] [kafka] guozhangwang commented on pull request #11451: [WIP] KAFKA-13419: resetStateAndRejoin when rebalanceInProgress in syncgroup

[GitBox <gi...@apache.org>]

guozhangwang commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-958155691


   Hi @showuon I think we were referring to different things :) There are different places where we encode the assigned partitions as well as generation:
   
   1) Inside the `ConsumerCoordinator#subscriptions`, where we save the currently assigned partitions.
   2) Inside the `Assignor#userData`, where for (cooperative) sticky assignor where we also encode the generation and the prev-assigned partitions as `memberAssignment` (note that in join-group request we do not encode the generation id).
   
   My above comment is referring to 2) above, which is only set upon `onAssignment`, which means that, even if any things happens that caused the consumer to revoke previously owned partitions, the user data would still encode those partitions to the sticky assignor.
   
   Maybe you are trying to fix 1) above only, in which case that's also fine, but do you feel 2) is also an issue that needs to be fixed separately?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org