You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/02 02:19:27 UTC

[GitHub] [shardingsphere-elasticjob] Technoboy- commented on issue #1430: OneOffJobBootstrap doesn't support parameters

Technoboy- commented on issue #1430:
URL: https://github.com/apache/shardingsphere-elasticjob/issues/1430#issuecomment-685244556


   > In my opinion, OneOffJob is a type of Bootstrap and SimpleJob or FlowJob are types of ElasticJob, they are different concepts. Parameters can be provided by JobConfiguration and distinguish by ShardingContext. Just create a custom implementation of JobItemExecutor and you can get JobConfiguration and ShardingContext. There is no need to change the API of OneOffJobBootstrap.
   > What do you think? @Technoboy- @specYyt
   
   Yes, keep the current api, and will support parameters in JobConfiguration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org