You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/30 22:11:24 UTC

[GitHub] [iceberg] huaxingao opened a new pull request, #5172: Check getBloomFilterOffset() <= 0 for non bloom filter

huaxingao opened a new pull request, #5172:
URL: https://github.com/apache/iceberg/pull/5172

   We saw parquet files (don't have bloom filters) with `bloomFilterOffset = 0`  :(
   
   This is a known [bug](https://issues.apache.org/jira/browse/PARQUET-1979). It was fixed before the bloom filter was released in parquet-mr 1.12.0, but I guess it's possible people may use the unofficial released parquet-mr (which has the bloom filter support but doesn't have the offset bug fix), so change the check to be `getBloomFilterOffset() <= 0` to be safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #5172: Check getBloomFilterOffset() <= 0 for non bloom filter

Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5172:
URL: https://github.com/apache/iceberg/pull/5172#issuecomment-1171775977

   Thanks, @huaxingao!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] huaxingao commented on pull request #5172: Check getBloomFilterOffset() <= 0 for non bloom filter

Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #5172:
URL: https://github.com/apache/iceberg/pull/5172#issuecomment-1171766002

   cc @rdblue @RussellSpitzer 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] huaxingao commented on pull request #5172: Check getBloomFilterOffset() <= 0 for non bloom filter

Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #5172:
URL: https://github.com/apache/iceberg/pull/5172#issuecomment-1171776298

   Thanks @rdblue @RussellSpitzer 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] RussellSpitzer commented on pull request #5172: Check getBloomFilterOffset() <= 0 for non bloom filter

Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on PR #5172:
URL: https://github.com/apache/iceberg/pull/5172#issuecomment-1171774937

   Thanks @huaxingao for fixing this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue merged pull request #5172: Check getBloomFilterOffset() <= 0 for non bloom filter

Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5172:
URL: https://github.com/apache/iceberg/pull/5172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org