You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Trustin Lee <tr...@gmail.com> on 2005/06/17 18:02:17 UTC

Re: svn commit: r190949 - in /directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/jndi: AbstractContextFactory.java ContextFactoryConfiguration.java ContextFactoryContext.java CoreContextFactory.java DefaultContextFactoryConfiguration.

Alex, can I know why did you change ContextFactoryContext to 
ContextFactoryConfiguration? It is not a configuration, but is used to 
provide narrowed view of ApacheDS core to extenders of 
AbstractContextFactory. And moreover it doesn't provide anything to 
configure. That's why I named it 'Context' (not JNDI context, but context in 
ServletContext)
 Trustin

 2005/6/17, akarasulu@apache.org <ak...@apache.org>: 
> 
> Author: akarasulu
> Date: Thu Jun 16 09:27:47 2005
> New Revision: 190949
> 
> URL: http://svn.apache.org/viewcvs?rev=190949&view=rev
> Log:
> renaming ContextFactoryContext to ContextFactoryConfiguration: did same 
> with defualt bean for this interface

 Trustin
-- 
what we call human nature is actually human habit
--
http://gleamynode.net/

Re: svn commit: r190949 - in /directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/jndi: AbstractContextFactory.java ContextFactoryConfiguration.java ContextFactoryContext.java CoreContextFactory.java DefaultContextFactoryConfiguration.

Posted by Enrique Rodriguez <en...@gmail.com>.
Alex Karasulu wrote:
> I know what you're thinking :-).  Alex is on one of his naming sprees 
> ... really it confused the heck out of me.  There are contexts all over 
> the place.
> Alex

ContextSomethingContext is a particularly odd name.

Enrique


Re: svn commit: r190949 - in /directory/apacheds/trunk/core/src/main/java/org/apache/ldap/server/jndi: AbstractContextFactory.java ContextFactoryConfiguration.java ContextFactoryContext.java CoreContextFactory.java DefaultContextFactoryConfiguration.

Posted by Alex Karasulu <ao...@bellsouth.net>.
Trustin Lee wrote:

> Alex, can I know why did you change ContextFactoryContext to 
> ContextFactoryConfiguration?  It is not a configuration, but is used 
> to provide narrowed view of ApacheDS core to extenders of 
> AbstractContextFactory.  And moreover it doesn't provide anything to 
> configure.  That's why I named it 'Context' (not JNDI context, but 
> context in  ServletContext)

I messed up and thought it was a config bean.  I did not know this was 
the replacement for the JndiProvider.  Was trying to remove confusion 
between the JNDI Context and ApacheDS Factory Context that you intended 
this to be.  I'll change it back or better yet we can change it once we 
figure out a better name to call it.

I know what you're thinking :-).  Alex is on one of his naming sprees 
... really it confused the heck out of me.  There are contexts all over 
the place. 

Alex

> 2005/6/17, akarasulu@apache.org <ma...@apache.org> 
> <akarasulu@apache.org <ma...@apache.org>>:
>
>     Author: akarasulu
>     Date: Thu Jun 16 09:27:47 2005
>     New Revision: 190949
>
>     URL: http://svn.apache.org/viewcvs?rev=190949&view=rev
>     <http://svn.apache.org/viewcvs?rev=190949&view=rev>
>     Log:
>     renaming ContextFactoryContext to ContextFactoryConfiguration: did
>     same with defualt bean for this interface
>
>  
> Trustin
> -- 
> what we call human nature is actually human habit
> --
> http://gleamynode.net/