You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/12/02 03:11:31 UTC
[kudu-CR] more strict check for [un]setenv() return code
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20744
Change subject: more strict check for [un]setenv() return code
......................................................................
more strict check for [un]setenv() return code
Even if setenv() and unsetenv() function expected to almost never fail
with the current code as per documentation [1], it still makes sense
to check for their return code. This patch updates the call sites
of these functions accordingly.
I also addressed a few warnings that ClangTidy produced
on the updated code.
[1] https://man7.org/linux/man-pages/man3/setenv.3.html
Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/client/client-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/security/init.cc
M src/kudu/security/test/mini_kdc.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
10 files changed, 43 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/20744/1
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20744 )
Change subject: more strict check for [un]setenv() return code
......................................................................
more strict check for [un]setenv() return code
Even if setenv() and unsetenv() function expected to almost never fail
with the current code as per documentation [1], it still makes sense
to check for their return code. This patch updates the call sites
of these functions accordingly.
I also addressed a few warnings that ClangTidy produced
on the updated code.
[1] https://man7.org/linux/man-pages/man3/setenv.3.html
Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Reviewed-on: http://gerrit.cloudera.org:8080/20744
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/client/client-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/security/init.cc
M src/kudu/security/test/mini_kdc.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
10 files changed, 42 insertions(+), 34 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Mahesh Reddy: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 )
Change subject: more strict check for [un]setenv() return code
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 04 Dec 2023 18:24:22 +0000
Gerrit-HasComments: No
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 )
Change subject: more strict check for [un]setenv() return code
......................................................................
Patch Set 1: Verified+1
unrelated test flake in KeepAlivePeriodically/KeepAlivePeriodicallyTest (it's a known issue)
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Dec 2023 04:11:00 +0000
Gerrit-HasComments: No
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 )
Change subject: more strict check for [un]setenv() return code
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20744/1/src/kudu/security/init.cc
File src/kudu/security/init.cc:
http://gerrit.cloudera.org:8080/#/c/20744/1/src/kudu/security/init.cc@519
PS1, Line 519: g_kinit_ctx = new KinitContext;
> Is this change needed?
Whoops: nope, this isn't not. This shouldn't be a part of this changelist.
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 04 Dec 2023 17:54:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: more strict check for [un]setenv() return code
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 )
Change subject: more strict check for [un]setenv() return code
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20744/1/src/kudu/security/init.cc
File src/kudu/security/init.cc:
http://gerrit.cloudera.org:8080/#/c/20744/1/src/kudu/security/init.cc@519
PS1, Line 519: g_kinit_ctx = new KinitContext;
Is this change needed?
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 04 Dec 2023 08:11:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20744
to look at the new patch set (#2).
Change subject: more strict check for [un]setenv() return code
......................................................................
more strict check for [un]setenv() return code
Even if setenv() and unsetenv() function expected to almost never fail
with the current code as per documentation [1], it still makes sense
to check for their return code. This patch updates the call sites
of these functions accordingly.
I also addressed a few warnings that ClangTidy produced
on the updated code.
[1] https://man7.org/linux/man-pages/man3/setenv.3.html
Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/client/client-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/security/init.cc
M src/kudu/security/test/mini_kdc.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
10 files changed, 42 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/20744/2
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 )
Change subject: more strict check for [un]setenv() return code
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 05 Dec 2023 04:09:05 +0000
Gerrit-HasComments: No
[kudu-CR] more strict check for [un]setenv() return code
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20744 )
Change subject: more strict check for [un]setenv() return code
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 04 Dec 2023 18:08:01 +0000
Gerrit-HasComments: No