You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Dan Haywood (JIRA)" <ji...@apache.org> on 2010/11/04 17:19:43 UTC
[jira] Created: (ISIS-9) Fixes to the Eclipse templates
Fixes to the Eclipse templates
------------------------------
Key: ISIS-9
URL: https://issues.apache.org/jira/browse/ISIS-9
Project: Isis
Issue Type: Improvement
Reporter: Dan Haywood
Assignee: Kevin Meyer
Priority: Minor
This was an email chain from Jul 2010 timeframe, against NOF 4.0.0. Kevin had the proposed changes, I've assigned to him.
~~~~~~~~~~~
Sounds like those are the right templates then (there hasn't been any updates to em). I'll check it out, but if you reckon there's a bug and you have a fix, then go ahead and commit the changes (somewhere under trunk/distribution, if i remember right).
Thanks,
Dan
Sent from my iPhone
On 28 Jul 2010, at 11:28, "Kevin Meyer" <ke...@kmz.co.za> wrote:
> > Hi Dan,
> >
>> >> Yes, the parent should do the work, and the child delegate to it. It's
>> >> called the mutual registration pattern.
> >
> > That is what I understood. I wanted to confirm with you as I was seeing
> > some funny behaviour.
> >
>> >> In your email you talk about the 'template' in the singular, but actually
>> >> there are several templates available (I'm assuming you are using the ones
>> >> I describe in my book?).
> >
> > I'm using the templates I fetched from the NOF
> > "/distribution/tarball/.../ide/eclipse/templates" directory.
> > I should compare them to the ones in your book...
> >
>> >> I don't think that there are any bugs in them; rob says he's been using
>> >> them ok (though I think he trimmed them down a bit).
> >
> > The issue that I have with the 'noc-1m' "1:m parent" association
> > template is that following two lines are the wrong way around?:
> > // associate arg
> > childElementName.setParentPropertyNameInChild(this);
> > getChildCollectionName().add(childElementName);
> >
> > Since, if the child method "setParentPropertyNameInChild(this)"
> > delegates to the parent (e.g. contains
> > "parentObject.addToChildCollectionName(this)") then you've got
> > an infinite recursion taking place - the child item is not yet
> > in the parent collection, when the parent calls the child... :-o
> >
> > AFAIK, There is no equivalent child template ('nocmod' assumes no
> > parent?).
> >
> >
> >
> > Regards,
> > Kevin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (ISIS-9) Fixes to the Eclipse templates
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood updated ISIS-9:
---------------------------
Fix Version/s: (was: 0.1.2-incubating)
0.2.0-incubating
> Fixes to the Eclipse templates
> ------------------------------
>
> Key: ISIS-9
> URL: https://issues.apache.org/jira/browse/ISIS-9
> Project: Isis
> Issue Type: Improvement
> Components: isis-parent (build plugins + site)
> Reporter: Dan Haywood
> Assignee: Kevin Meyer
> Priority: Minor
> Fix For: 0.2.0-incubating
>
>
> This was an email chain from Jul 2010 timeframe, against NOF 4.0.0. Kevin had the proposed changes, I've assigned to him.
> ~~~~~~~~~~~
> Sounds like those are the right templates then (there hasn't been any updates to em). I'll check it out, but if you reckon there's a bug and you have a fix, then go ahead and commit the changes (somewhere under trunk/distribution, if i remember right).
> Thanks,
> Dan
> Sent from my iPhone
> On 28 Jul 2010, at 11:28, "Kevin Meyer" <ke...@kmz.co.za> wrote:
> > > Hi Dan,
> > >
> >> >> Yes, the parent should do the work, and the child delegate to it. It's
> >> >> called the mutual registration pattern.
> > >
> > > That is what I understood. I wanted to confirm with you as I was seeing
> > > some funny behaviour.
> > >
> >> >> In your email you talk about the 'template' in the singular, but actually
> >> >> there are several templates available (I'm assuming you are using the ones
> >> >> I describe in my book?).
> > >
> > > I'm using the templates I fetched from the NOF
> > > "/distribution/tarball/.../ide/eclipse/templates" directory.
> > > I should compare them to the ones in your book...
> > >
> >> >> I don't think that there are any bugs in them; rob says he's been using
> >> >> them ok (though I think he trimmed them down a bit).
> > >
> > > The issue that I have with the 'noc-1m' "1:m parent" association
> > > template is that following two lines are the wrong way around?:
> > > // associate arg
> > > childElementName.setParentPropertyNameInChild(this);
> > > getChildCollectionName().add(childElementName);
> > >
> > > Since, if the child method "setParentPropertyNameInChild(this)"
> > > delegates to the parent (e.g. contains
> > > "parentObject.addToChildCollectionName(this)") then you've got
> > > an infinite recursion taking place - the child item is not yet
> > > in the parent collection, when the parent calls the child... :-o
> > >
> > > AFAIK, There is no equivalent child template ('nocmod' assumes no
> > > parent?).
> > >
> > >
> > >
> > > Regards,
> > > Kevin
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ISIS-9) Fixes to the Eclipse templates
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood updated ISIS-9:
---------------------------
Fix Version/s: 0.1.0-incubating
> Fixes to the Eclipse templates
> ------------------------------
>
> Key: ISIS-9
> URL: https://issues.apache.org/jira/browse/ISIS-9
> Project: Isis
> Issue Type: Improvement
> Reporter: Dan Haywood
> Assignee: Kevin Meyer
> Priority: Minor
> Fix For: 0.1.0-incubating
>
>
> This was an email chain from Jul 2010 timeframe, against NOF 4.0.0. Kevin had the proposed changes, I've assigned to him.
> ~~~~~~~~~~~
> Sounds like those are the right templates then (there hasn't been any updates to em). I'll check it out, but if you reckon there's a bug and you have a fix, then go ahead and commit the changes (somewhere under trunk/distribution, if i remember right).
> Thanks,
> Dan
> Sent from my iPhone
> On 28 Jul 2010, at 11:28, "Kevin Meyer" <ke...@kmz.co.za> wrote:
> > > Hi Dan,
> > >
> >> >> Yes, the parent should do the work, and the child delegate to it. It's
> >> >> called the mutual registration pattern.
> > >
> > > That is what I understood. I wanted to confirm with you as I was seeing
> > > some funny behaviour.
> > >
> >> >> In your email you talk about the 'template' in the singular, but actually
> >> >> there are several templates available (I'm assuming you are using the ones
> >> >> I describe in my book?).
> > >
> > > I'm using the templates I fetched from the NOF
> > > "/distribution/tarball/.../ide/eclipse/templates" directory.
> > > I should compare them to the ones in your book...
> > >
> >> >> I don't think that there are any bugs in them; rob says he's been using
> >> >> them ok (though I think he trimmed them down a bit).
> > >
> > > The issue that I have with the 'noc-1m' "1:m parent" association
> > > template is that following two lines are the wrong way around?:
> > > // associate arg
> > > childElementName.setParentPropertyNameInChild(this);
> > > getChildCollectionName().add(childElementName);
> > >
> > > Since, if the child method "setParentPropertyNameInChild(this)"
> > > delegates to the parent (e.g. contains
> > > "parentObject.addToChildCollectionName(this)") then you've got
> > > an infinite recursion taking place - the child item is not yet
> > > in the parent collection, when the parent calls the child... :-o
> > >
> > > AFAIK, There is no equivalent child template ('nocmod' assumes no
> > > parent?).
> > >
> > >
> > >
> > > Regards,
> > > Kevin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (ISIS-9) Fixes to the Eclipse templates
Posted by "Dan Haywood (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood updated ISIS-9:
---------------------------
Affects Version/s: (was: 0.3.0-incubating)
0.1.2-incubating
Fix Version/s: (was: 0.2.0-incubating)
0.3.0-incubating
Pushing back to next release.
> Fixes to the Eclipse templates
> ------------------------------
>
> Key: ISIS-9
> URL: https://issues.apache.org/jira/browse/ISIS-9
> Project: Isis
> Issue Type: Improvement
> Components: isis-parent (build plugins + site)
> Affects Versions: 0.1.2-incubating
> Reporter: Dan Haywood
> Assignee: Kevin Meyer
> Priority: Minor
> Fix For: 0.3.0-incubating
>
>
> This was an email chain from Jul 2010 timeframe, against NOF 4.0.0. Kevin had the proposed changes, I've assigned to him.
> ~~~~~~~~~~~
> Sounds like those are the right templates then (there hasn't been any updates to em). I'll check it out, but if you reckon there's a bug and you have a fix, then go ahead and commit the changes (somewhere under trunk/distribution, if i remember right).
> Thanks,
> Dan
> Sent from my iPhone
> On 28 Jul 2010, at 11:28, "Kevin Meyer" <ke...@kmz.co.za> wrote:
> > > Hi Dan,
> > >
> >> >> Yes, the parent should do the work, and the child delegate to it. It's
> >> >> called the mutual registration pattern.
> > >
> > > That is what I understood. I wanted to confirm with you as I was seeing
> > > some funny behaviour.
> > >
> >> >> In your email you talk about the 'template' in the singular, but actually
> >> >> there are several templates available (I'm assuming you are using the ones
> >> >> I describe in my book?).
> > >
> > > I'm using the templates I fetched from the NOF
> > > "/distribution/tarball/.../ide/eclipse/templates" directory.
> > > I should compare them to the ones in your book...
> > >
> >> >> I don't think that there are any bugs in them; rob says he's been using
> >> >> them ok (though I think he trimmed them down a bit).
> > >
> > > The issue that I have with the 'noc-1m' "1:m parent" association
> > > template is that following two lines are the wrong way around?:
> > > // associate arg
> > > childElementName.setParentPropertyNameInChild(this);
> > > getChildCollectionName().add(childElementName);
> > >
> > > Since, if the child method "setParentPropertyNameInChild(this)"
> > > delegates to the parent (e.g. contains
> > > "parentObject.addToChildCollectionName(this)") then you've got
> > > an infinite recursion taking place - the child item is not yet
> > > in the parent collection, when the parent calls the child... :-o
> > >
> > > AFAIK, There is no equivalent child template ('nocmod' assumes no
> > > parent?).
> > >
> > >
> > >
> > > Regards,
> > > Kevin
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ISIS-9) Fixes to the Eclipse templates
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood updated ISIS-9:
---------------------------
Fix Version/s: (was: 0.3.1-incubating)
> Fixes to the Eclipse templates
> ------------------------------
>
> Key: ISIS-9
> URL: https://issues.apache.org/jira/browse/ISIS-9
> Project: Isis
> Issue Type: Improvement
> Components: isis-parent (build plugins + site)
> Affects Versions: 0.1.2-incubating
> Reporter: Dan Haywood
> Assignee: Kevin Meyer
> Priority: Minor
>
> This was an email chain from Jul 2010 timeframe, against NOF 4.0.0. Kevin had the proposed changes, I've assigned to him.
> ~~~~~~~~~~~
> Sounds like those are the right templates then (there hasn't been any updates to em). I'll check it out, but if you reckon there's a bug and you have a fix, then go ahead and commit the changes (somewhere under trunk/distribution, if i remember right).
> Thanks,
> Dan
> Sent from my iPhone
> On 28 Jul 2010, at 11:28, "Kevin Meyer" <ke...@kmz.co.za> wrote:
> > > Hi Dan,
> > >
> >> >> Yes, the parent should do the work, and the child delegate to it. It's
> >> >> called the mutual registration pattern.
> > >
> > > That is what I understood. I wanted to confirm with you as I was seeing
> > > some funny behaviour.
> > >
> >> >> In your email you talk about the 'template' in the singular, but actually
> >> >> there are several templates available (I'm assuming you are using the ones
> >> >> I describe in my book?).
> > >
> > > I'm using the templates I fetched from the NOF
> > > "/distribution/tarball/.../ide/eclipse/templates" directory.
> > > I should compare them to the ones in your book...
> > >
> >> >> I don't think that there are any bugs in them; rob says he's been using
> >> >> them ok (though I think he trimmed them down a bit).
> > >
> > > The issue that I have with the 'noc-1m' "1:m parent" association
> > > template is that following two lines are the wrong way around?:
> > > // associate arg
> > > childElementName.setParentPropertyNameInChild(this);
> > > getChildCollectionName().add(childElementName);
> > >
> > > Since, if the child method "setParentPropertyNameInChild(this)"
> > > delegates to the parent (e.g. contains
> > > "parentObject.addToChildCollectionName(this)") then you've got
> > > an infinite recursion taking place - the child item is not yet
> > > in the parent collection, when the parent calls the child... :-o
> > >
> > > AFAIK, There is no equivalent child template ('nocmod' assumes no
> > > parent?).
> > >
> > >
> > >
> > > Regards,
> > > Kevin
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ISIS-9) Fixes to the Eclipse templates
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ISIS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood updated ISIS-9:
---------------------------
Component/s: isis-parent (build plugins + site)
> Fixes to the Eclipse templates
> ------------------------------
>
> Key: ISIS-9
> URL: https://issues.apache.org/jira/browse/ISIS-9
> Project: Isis
> Issue Type: Improvement
> Components: isis-parent (build plugins + site)
> Reporter: Dan Haywood
> Assignee: Kevin Meyer
> Priority: Minor
> Fix For: 0.1.0-incubating
>
>
> This was an email chain from Jul 2010 timeframe, against NOF 4.0.0. Kevin had the proposed changes, I've assigned to him.
> ~~~~~~~~~~~
> Sounds like those are the right templates then (there hasn't been any updates to em). I'll check it out, but if you reckon there's a bug and you have a fix, then go ahead and commit the changes (somewhere under trunk/distribution, if i remember right).
> Thanks,
> Dan
> Sent from my iPhone
> On 28 Jul 2010, at 11:28, "Kevin Meyer" <ke...@kmz.co.za> wrote:
> > > Hi Dan,
> > >
> >> >> Yes, the parent should do the work, and the child delegate to it. It's
> >> >> called the mutual registration pattern.
> > >
> > > That is what I understood. I wanted to confirm with you as I was seeing
> > > some funny behaviour.
> > >
> >> >> In your email you talk about the 'template' in the singular, but actually
> >> >> there are several templates available (I'm assuming you are using the ones
> >> >> I describe in my book?).
> > >
> > > I'm using the templates I fetched from the NOF
> > > "/distribution/tarball/.../ide/eclipse/templates" directory.
> > > I should compare them to the ones in your book...
> > >
> >> >> I don't think that there are any bugs in them; rob says he's been using
> >> >> them ok (though I think he trimmed them down a bit).
> > >
> > > The issue that I have with the 'noc-1m' "1:m parent" association
> > > template is that following two lines are the wrong way around?:
> > > // associate arg
> > > childElementName.setParentPropertyNameInChild(this);
> > > getChildCollectionName().add(childElementName);
> > >
> > > Since, if the child method "setParentPropertyNameInChild(this)"
> > > delegates to the parent (e.g. contains
> > > "parentObject.addToChildCollectionName(this)") then you've got
> > > an infinite recursion taking place - the child item is not yet
> > > in the parent collection, when the parent calls the child... :-o
> > >
> > > AFAIK, There is no equivalent child template ('nocmod' assumes no
> > > parent?).
> > >
> > >
> > >
> > > Regards,
> > > Kevin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.