You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/06 03:22:51 UTC

[GitHub] [kafka] C0urante opened a new pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

C0urante opened a new pull request #10074:
URL: https://github.com/apache/kafka/pull/10074


   [Jira](https://issues.apache.org/jira/browse/KAFKA-12305)
   
   (Copied from Jira):
   
   The `Flatten` SMT fails for array types. A sophisticated approach that tries to flatten arrays might be desirable in some cases, and may have been punted during the early design phase of the transform, but in the interim, it's probably not worth it to make array data and the SMT mutually exclusive.
   
   A naive approach that preserves arrays as-are and doesn't attempt to flatten them seems fair for now.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley merged pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

Posted by GitBox <gi...@apache.org>.
tombentley merged pull request #10074:
URL: https://github.com/apache/kafka/pull/10074


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10074:
URL: https://github.com/apache/kafka/pull/10074#issuecomment-824801861


   Thanks @tombentley--good call on updating the docs; I've done that. RE a test for the recursive case--I don't think it'll hurt, so I updated the existing tests to include it. Probably not too valuable right now since arrays are just passed through unmodified but it might save someone else that bit of legwork in the future if we decide we want bona fide flattening for array types as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10074:
URL: https://github.com/apache/kafka/pull/10074#issuecomment-891822887


   @C0urante sorry for the delay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10074:
URL: https://github.com/apache/kafka/pull/10074#issuecomment-885046027


   @tombentley know it's been a while and we're probably past the boat for 3.0, but wanted to check in and see if there's anything blocking this PR from being merged at the moment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10074:
URL: https://github.com/apache/kafka/pull/10074#issuecomment-779866655


   @gharris1727 @ncliang @tombentley anyone got time to take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org