[GitHub] [cordova-plugin-camera] jcesarmobile commented on a change in pull request #749: feat: bump plugin version for next major

[GitBox <gi...@apache.org>]

jcesarmobile commented on a change in pull request #749:
URL: https://github.com/apache/cordova-plugin-camera/pull/749#discussion_r681657751



##########
File path: package.json
##########
@@ -45,6 +45,11 @@
         "cordova-ios": ">=5.1.0",
         "cordova": ">=9.0.0"
       },
+      "5.0.3": {
+        "cordova-android": "<10.0.0",
+        "cordova-ios": ">=5.1.0",
+        "cordova": ">=9.0.0"
+      },
       "6.0.0": {

Review comment:
       6.0.0 should include new engines and the >100 should be for a 7.0.0 entry

##########
File path: plugin.xml
##########
@@ -31,7 +31,7 @@
 
     <engines>
         <engine name="cordova" version=">=9.0.0"/>
-        <engine name="cordova-android" version=">=9.0.0" />
+        <engine name="cordova-android" version="<10.0.0" />

Review comment:
       Should be 
   ```suggestion
           <engine name="cordova-android" version=">=10.0.0" />
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org