[jira] [Closed] (OFBIZ-9164) Refactor ContentWorkerInterface methods signatures

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-9164.
----------------------------------
    Resolution: Implemented

> Refactor ContentWorkerInterface methods signatures
> --------------------------------------------------
>
>                 Key: OFBIZ-9164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9164
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: content, framework, lucene, order, party, product, workeffort
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-9164 DataResourceWorker.java.patch, OFBIZ-9164.patch
>
>
> While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an issue due to r1652852 where Adrian improved the cacheKey in FormFactory.getFormFromLocation() by adding a delegator reference (Tenants). Actually I'm not even sure it was done at r1652852 because Adrian did not maintain the FormFactory svn history.
> Anyway, to make a long story short I had to introduce a DispatchContext parameter when calling FormFactory.readFormDocument() when the code from R13.07 only passed a null.
> This had an impact in the hierarchy tree because FormFactory.readFormDocument() was called in DataResourceWorker class, where the new code was called from renderDataResourceAsText(). So I instead of only passing a Delegator I decided to pass only a LocalDispatcher parameter in renderDataResourceAsText(), since we can get the Delegator  from the LocalDispatcher. Doing so it had an impact on the renderDataResourceAsText hierarchy tree ending in DataResourceWorkerInterface and all related.
>  I finally decided to apply the same ["Change Method Signature" refactoring pattern|http://refactoring.com/catalog/addParameter.html] to all cases related to ContentWorkerInterface. No need to pass a delegator when you have LocalDispatcher!
> Here I attach a patch for review, I'll commit in few days



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)