[jira] [Commented] (AIRFLOW-4908) Implement BigQuery Hooks/Operators for update_dataset, patch_dataset and get_dataset

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880095#comment-16880095 ] 

ASF GitHub Bot commented on AIRFLOW-4908:
-----------------------------------------

ryanyuan commented on pull request #5546: [AIRFLOW-4908] BigQuery Hooks/Operators for update_dataset, patch_dataset, get_dataset
URL: https://github.com/apache/airflow/pull/5546
 
 
   To create a BigQuery sink for GCP Stackdriver Logging, I have to assign `WRITER` access to group `cloud-logs@google.com` to access BQ dataset. However, current BigQueryHook doesn't support updating/patching dataset.
   
   Reference: https://googleapis.github.io/google-cloud-python/latest/logging/usage.html#export-to-bigquery
   
   Implement GCP Stackdriver Logging: [AIRFLOW-4779](https://issues.apache.org/jira/browse/AIRFLOW-4779)
   
   While it is missing update_dataset and patch_dataset, BigQueryHook has get_dataset but it doesn't have operator for it.
   
   Features to be implemented:
   BigQueryBaseCursor.patch_dataset
   BigQueryBaseCursor.update_dataset
   BigQueryPatchDatasetOperator
   BigQueryUpdateDatasetOperator
   BigQueryGetDatasetOperator
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow-4908](https://issues.apache.org/jira/browse/AIRFLOW-4908) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   test_bigquery_operator:BigQueryPatchDatasetOperatorTest
   test_bigquery_operator:BigQueryGetDatasetOperatorTest
   test_bigquery_operator:BigQueryUpdateDatasetOperatorTest
   test_bigquery_hook:TestDatasetsOperations.test_patch_dataset
   test_bigquery_hook:TestDatasetsOperations.test_update_dataset
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Implement BigQuery Hooks/Operators for update_dataset, patch_dataset and get_dataset
> ------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4908
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4908
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: gcp
>    Affects Versions: 2.0.0
>            Reporter: Ryan Yuan
>            Assignee: Ryan Yuan
>            Priority: Critical
>
> To create a BigQuery sink for GCP Stackdriver Logging, I have to assign `WRITER` access to group `cloud-logs@google.com` to access BQ dataset. However, current BigQueryHook doesn't support updating/patching dataset.
> Reference: [https://googleapis.github.io/google-cloud-python/latest/logging/usage.html#export-to-bigquery]
> Implement GCP Stackdriver Logging: https://issues.apache.org/jira/browse/AIRFLOW-4779
> While it is missing update_dataset and patch_dataset, BigQueryHook has get_dataset but it doesn't have operator for it.
>  
> Features to be implemented:
> BigQueryBaseCursor.patch_dataset
> BigQueryBaseCursor.update_dataset
> BigQueryPatchDatasetOperator
> BigQueryUpdateDatasetOperator
> BigQueryGetDatasetOperator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)