You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/26 16:13:08 UTC

[GitHub] [geode] DonalEvans commented on pull request #5313: GEODE-8302: Fixed 'events not queued conflated' stats when group-tran…

DonalEvans commented on pull request #5313:
URL: https://github.com/apache/geode/pull/5313#issuecomment-650264150


   When the following diff is applied, the modified test `testPartitionedSerialPropagationHA()` also fails with incorrectly conflated events. Since this test does not set `groupTransactionEvents` to true, it seems like there is more to this issue.
   
   `diff --git a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java
   index 9e80bab9aa..59b5b7a903 100644
   --- a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java
   +++ b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANPropagation_PartitionedRegionDUnitTest.java
   @@ -330,6 +330,8 @@ public class SerialWANPropagation_PartitionedRegionDUnitTest extends WANTestBase
        inv.join();
        vm2.invoke(() -> WANTestBase.validateRegionSize(getTestMethodName() + "_PR", 1000));
        vm3.invoke(() -> WANTestBase.validateRegionSize(getTestMethodName() + "_PR", 1000));
   +    vm4.invoke(() -> WANTestBase.checkConflatedStats("ln", 0));
   +    vm5.invoke(() -> WANTestBase.checkConflatedStats("ln", 0));
      }
    
      @Test
   `


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org