You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/03/05 21:51:43 UTC

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

Tim Armstrong has uploaded a new patch set (#4) to the change originally created by Tianyi Wang. ( http://gerrit.cloudera.org:8080/10679 )

Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc
......................................................................

IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

To inline calls to Compare() in TupleSorter, we need to cross compile
TupleSorter to LLVM-IR first.
This patch also adopted some clang-tidy suggestions including using
nullptr.

Change-Id: Iaaf2b75c2f789002c42939865c018f728d29a113
---
M be/src/codegen/impala-ir.cc
M be/src/runtime/CMakeLists.txt
A be/src/runtime/sorter-internal.h
A be/src/runtime/sorter-ir.cc
M be/src/runtime/sorter.cc
5 files changed, 903 insertions(+), 823 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/10679/4
-- 
To view, visit http://gerrit.cloudera.org:8080/10679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaaf2b75c2f789002c42939865c018f728d29a113
Gerrit-Change-Number: 10679
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>