[jira] [Commented] (FLINK-27778) table-planner should not use CodeSplitUtils#newName

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542856#comment-17542856 ] 

Chesnay Schepler commented on FLINK-27778:
------------------------------------------

Reached out to [~tiwalter]; the planner is using the wrong method; it should use {{CodeGenUtils#newName}} instead.

> table-planner should not use CodeSplitUtils#newName
> ---------------------------------------------------
>
>                 Key: FLINK-27778
>                 URL: https://issues.apache.org/jira/browse/FLINK-27778
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Build System, Table SQL / Planner
>            Reporter: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.16.0
>
>
> The {{table-planner}} has a direct dependency on the {{table-code-splitter}}, as several CastRules use {{CodeSplitUtil.newName}}.
> This dependency is a bit hidden. In the IDE it is pulled in transitively via {{table-runtime}}, and in maven it uses the {{table-code-splitter}} dependency bundled by {{table-runtime}}.
> It would be nice if we could add a {{provided}} dependency to the {{table-code-splitter}} to properly document this.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)