You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by kinow <gi...@git.apache.org> on 2017/10/31 02:34:27 UTC
[GitHub] jena pull request #302: Fixing tests on Windows for 3.5.0 RC2
GitHub user kinow opened a pull request:
https://github.com/apache/jena/pull/302
Fixing tests on Windows for 3.5.0 RC2
While testing 3.5.0 RC2 on Windows found another test failure. Spent some five minutes looking into this, and turns out it could be fixed by the `TemporaryFolder` rule too.
Previously, I mistakenly used `toString()` on the `TemporaryFolder`, but that prints the wrong data. You need to actually call `getRoot()` (or `newFolder()` if you want a new temp folder).
Fixed that in the previous test as well.
But more importantly, there is a limitation in `jena/tdb2/sys/DatabaseOps.java`, where it uses the timestamp formatted with colons. However, Windows doesn't like colons in file names (see https://support.microsoft.com/en-us/help/289627/how-to-enable-file-name-character-translation).
So I removed the colon characters, and the time is now formatted with `yyyy-MM-dd_HHmmss`, but happy if someone has a better suggestion (feel free to update this PR if you have the rights to do so too).
With these changes, the build is passing on my Windows with `mvn clean test install -Pbootstrap` (and also with the `dev` profile).
Running `mvn clean test install` hangs during ElasticSearch tests. Looks like a test fails, and then the execution simply hangs. Ctrl+C stops the process, but then I have to manually kill the `java` process. Not related to this bug, and not an issue right now I guess.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kinow/jena fix-windows-tests-pre-350rc2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #302
----
commit 0464469085245794e1a539dbbea7a1852fbfc964
Author: Bruno P. Kinoshita <br...@yahoo.com.br>
Date: 2017-10-31T02:29:16Z
Fixing tests on Windows for 3.5.0 RC2
----
---
[GitHub] jena issue #302: Fixing tests on Windows for 3.5.0 RC2
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/302
Checked out pull request on Linux, and did a `mvn clean test install -Pdev`.
```
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Jena - Project .............................. SUCCESS [ 1.543 s]
[INFO] Apache Jena - Base Common Environment .............. SUCCESS [ 11.547 s]
[INFO] Apache Jena - Core ................................. SUCCESS [ 51.137 s]
[INFO] Apache Jena - ARQ (SPARQL 1.1 Query Engine) ........ SUCCESS [ 54.714 s]
[INFO] Apache Jena - RDF Connection ....................... SUCCESS [ 5.713 s]
[INFO] Apache Jena - TDB (Native Triple Store) ............ SUCCESS [ 19.287 s]
[INFO] Apache Jena - Database Operation Environment ....... SUCCESS [ 0.222 s]
[INFO] Apache Jena - DBOE Base ............................ SUCCESS [ 6.066 s]
[INFO] Apache Jena - DBOE Transactions .................... SUCCESS [ 6.666 s]
[INFO] Apache Jena - DBOE Indexes ......................... SUCCESS [ 3.474 s]
[INFO] Apache Jena - DBOE Index test suite ................ SUCCESS [ 4.812 s]
[INFO] Apache Jena - DBOE Transactional Datastructures .... SUCCESS [ 7.034 s]
[INFO] Apache Jena - TDB2 ................................. SUCCESS [ 14.188 s]
[INFO] Apache Jena - Libraries POM ........................ SUCCESS [ 0.467 s]
[INFO] Apache Jena - Command line tools ................... SUCCESS [ 11.576 s]
[INFO] Apache Jena - SPARQL Text Search ................... SUCCESS [ 13.293 s]
[INFO] Apache Jena - SPARQL Spatial Search ................ SUCCESS [ 7.659 s]
[INFO] Apache Jena - Fuseki - A SPARQL 1.1 Server ......... SUCCESS [ 0.167 s]
[INFO] Apache Jena - Fuseki Server Engine ................. SUCCESS [ 12.765 s]
[INFO] Apache Jena - Fuseki Embedded Server ............... SUCCESS [ 5.984 s]
[INFO] Apache Jena - Fuseki WAR File ...................... SUCCESS [ 3.617 s]
[INFO] Apache Jena - Fuseki Server Standalone Jar ......... SUCCESS [ 4.074 s]
[INFO] Apache Jena - Fuseki Basic Server .................. SUCCESS [ 4.668 s]
[INFO] Apache Jena - Fuseki Binary Distribution ........... SUCCESS [ 5.891 s]
[INFO] Apache Jena - Integration Testing .................. SUCCESS [ 3.858 s]
[INFO] Apache Jena ........................................ SUCCESS [ 0.427 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:21 min
[INFO] Finished at: 2017-10-31T16:20:00+13:00
[INFO] Final Memory: 99M/624M
[INFO] ------------------------------------------------------------------------
```
---
[GitHub] jena pull request #302: Fixing tests on Windows for 3.5.0 RC2
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/302
---