You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2014/04/15 22:40:00 UTC

[Apache Bloodhound] #800: bootstrap_ep used before assignment

#800: bootstrap_ep used before assignment
---------------------+--------------------
  Reporter:  olemis  |    Owner:
      Type:  defect  |   Status:  new
  Priority:  major   |  Version:  0.8.0dev
Resolution:          |
---------------------+--------------------
 There is a potential bug in our copy of  trac.web.main consisting in the
 fact that `bootstrap_ep` variable is used before assignment in the body of
 `dispatch_request` function .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/800>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #800: bootstrap_ep used before assignment

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#800: bootstrap_ep used before assignment
------------------------+-----------------------------------
  Reporter:  olemis     |      Owner:  olemis
      Type:  defect     |     Status:  closed
  Priority:  critical   |  Milestone:  Release 8
 Component:  trac core  |    Version:  0.8.0dev
Resolution:  fixed      |   Keywords:  web bootstrap handler
------------------------+-----------------------------------
Changes (by rjollos):

 * owner:  rjollos => olemis


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/800#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #800: bootstrap_ep used before assignment

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#800: bootstrap_ep used before assignment
------------------------+-----------------------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  closed
  Priority:  critical   |  Milestone:  Release 8
 Component:  trac core  |    Version:  0.8.0dev
Resolution:  fixed      |   Keywords:  web bootstrap handler
------------------------+-----------------------------------
Changes (by rjollos):

 * status:  review => closed
 * resolution:   => fixed


Comment:

 (In [1587754])

 0.8dev: Fixed unbound local variable errors when exception is raised. Refs
 #800.

 Patch by Olemis Lang.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/800#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #800: bootstrap_ep used before assignment

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#800: bootstrap_ep used before assignment
------------------------+-----------------------------------
  Reporter:  olemis     |      Owner:  olemis
      Type:  defect     |     Status:  accepted
  Priority:  critical   |  Milestone:
 Component:  trac core  |    Version:  0.8.0dev
Resolution:             |   Keywords:  web bootstrap handler
------------------------+-----------------------------------
Changes (by olemis):

 * keywords:   => web bootstrap handler
 * status:  new => accepted
 * component:   => trac core
 * owner:   => olemis
 * priority:  major => critical


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/800#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #800: bootstrap_ep used before assignment

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#800: bootstrap_ep used before assignment
------------------------+-----------------------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  review
  Priority:  critical   |  Milestone:  Release 8
 Component:  trac core  |    Version:  0.8.0dev
Resolution:             |   Keywords:  web bootstrap handler
------------------------+-----------------------------------
Changes (by olemis):

 * milestone:   => Release 8


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/800#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #800: bootstrap_ep used before assignment

Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#800: bootstrap_ep used before assignment
------------------------+-----------------------------------
  Reporter:  olemis     |      Owner:  rjollos
      Type:  defect     |     Status:  review
  Priority:  critical   |  Milestone:
 Component:  trac core  |    Version:  0.8.0dev
Resolution:             |   Keywords:  web bootstrap handler
------------------------+-----------------------------------
Changes (by olemis):

 * owner:  olemis => rjollos
 * status:  accepted => review


Comment:

 This change should fix it

 {{{#!diff

 Index: trac/trac/web/main.py
 ===================================================================
 --- trac/trac/web/main.py       (revision 1587296)
 +++ trac/trac/web/main.py       (working copy)
 @@ -383,7 +383,8 @@

      # Load handler for environment lookup and instantiation of request
 objects
      from trac.hooks import load_bootstrap_handler
 -    bootstrap = load_bootstrap_handler(environ['trac.bootstrap_handler'],
 +    bootstrap_ep = environ['trac.bootstrap_handler']
 +    bootstrap = load_bootstrap_handler(bootstrap_ep,
                                         environ.get('wsgi.errors'))

      # Determine the environment
 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/800#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker