You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/12/24 02:14:02 UTC
[GitHub] [zeppelin] amakaur opened a new pull request #3566: Save notebook
on clear all paragraph output [ZEPPELIN-4505]
amakaur opened a new pull request #3566: Save notebook on clear all paragraph output [ZEPPELIN-4505]
URL: https://github.com/apache/zeppelin/pull/3566
### What is this PR for?
Currently clear all paragraph output changes are only stored in memory. So, when zeppelin is restarted all of the output is displayed again on all of the notebooks.
This PR saves the changes made to notebook and updates are reflected also on a restart. So there's no inconsistencies before and after a restart.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4505
### How should this be tested?
- Create a notebook using Spark interpreter
- Create any output
- Trigger clear all paragraph output
- Restart zeppelin and paragraph output will be erased as expected.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] amakaur removed a comment on issue #3566:
[ZEPPELIN-4505] Save notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
amakaur removed a comment on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-569142213
build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] asfgit closed pull request #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] amakaur commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
amakaur commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-569142213
build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] amakaur commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
amakaur commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-569151646
@zjffdu i had to create a new PR to trigger travis build since i didn't turn on travis integration for the previous branches.
Here's a temp PR: https://github.com/apache/zeppelin/pull/3573
Travis link for temp PR: https://travis-ci.org/amakaur/zeppelin/builds/629825383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3566: Save notebook on clear
all paragraph output [ZEPPELIN-4505]
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3566: Save notebook on clear all paragraph output [ZEPPELIN-4505]
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-568820110
Thanks @amakaur PR LGTM.
2 Minor comments:
* Please change the title as [ZEPPELIN-xx] jira tilte
* Could you paste the travis link
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] amakaur commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
amakaur commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-569324868
@zjffdu sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] amakaur commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
amakaur commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-570467442
@zjffdu looks like all of the builds have succeeded https://travis-ci.org/amakaur/zeppelin/builds/630097911?utm_medium=notification&utm_source=email
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] amakaur commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
amakaur commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-569360486
@zjffdu i did rebase with master and build is failing on an existing test case ```Tests in error:
ParagraphActionsIT.testWidth:327->AbstractZeppelinIT.waitForParagraph:75->AbstractZeppelinIT.pollingWait:101 ยป Timeout```
https://travis-ci.org/amakaur/zeppelin/builds/630097911?utm_medium=notification&utm_source=email
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-569395603
@amakaur This kind of error is usually due to flaky test, you can restart that by click this button.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-570472007
Thanks @amakaur will merge if no more comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] amakaur commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
amakaur commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-570472527
@zjffdu perfect. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3566: [ZEPPELIN-4505] Save
notebook on clear all paragraph output
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3566: [ZEPPELIN-4505] Save notebook on clear all paragraph output
URL: https://github.com/apache/zeppelin/pull/3566#issuecomment-569175704
@amakaur Some travis test are failed, Could you do a rebase to retrigger the travis ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services