[GitHub] [rocketmq] xxd763795151 opened a new issue #2538: [Code Quality] Message trace data send failed, but the failed logs are semantically ambiguous

[GitBox <gi...@apache.org>]

xxd763795151 opened a new issue #2538:
URL: https://github.com/apache/rocketmq/issues/2538


   
   An exception occur when sending trace data, the logs as follows:
    ```
                       @Override
                       public void onException(Throwable e) {
                           log.info("send trace data ,the traceData is " + data);
                       }
   ```
   
   [log.info("send trace data ,the traceData is " + data)]： this can easily be mistaken for an ordinary log.
   
   I have sent a lot of message, but I can not find their trace data by the message id. I spent a lot of time looking for the cause. 
   I can not see the reason through the log. But when I debug the source code, I found the failed cause of sending trace data: I enable acl but I forgot to config the authority of RMQ_SYS_TRACE_TOPIC.
   
   If modify the code as follows(prompt has failed to send):
   ```
                       @Override
                       public void onException(Throwable e) {
                           log.info("send trace data failed, the traceData is " + data);
                       }
   ```
   or print exception info:
   ```
                       @Override
                       public void onException(Throwable e) {
                           log.warn("send trace data failed, the traceData is " + data, e);
                       }
   ```
   I think this way is more friendly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] francisoliverlee closed issue #2538: [Code Quality] Message trace data send failed, but the failed logs are semantically ambiguous

[GitBox <gi...@apache.org>]

francisoliverlee closed issue #2538:
URL: https://github.com/apache/rocketmq/issues/2538


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org