[Bug 58590] org.apache.catalina.realm.MemoryRealm can use backgroundProcess() to reload tomcat-users.xml when it changes

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=58590

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> ---
1. Code conventions:
http://tomcat.apache.org/getinvolved.html

Actually Sun's conventions but with spaces instead of tabs.

2. backgroundProcess() runs frequently. I see no need to perform this work on
each run.

3. It shall work without stopping and starting the realm. Users should not be
locked from the system while it reloads.

4. MemoryRealm is rarely used.  The usual configuration uses UserDatabaseRealm
+ MemoryUserDatabase (created by MemoryUserDatabaseFactory).

5. It should be possible to turn this feature on or off.

I do not know what the default should be.
On one hand we already have <Host autoDeploy="true"> so we are already checking
hard drive by default.

On other hand, on production systems such setting is likely to be off by
default (as there is an expectation that nobody will ever update that file).

6. There shall be an explicit method to reload and an explicit method to
perform an up-to-date check - so that it were possible to call them via JMX.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org