[GitHub] [ozone] sadanand48 commented on a diff in pull request #4082: HDDS-7641. namespace quota validation not present multiple places

[GitBox <gi...@apache.org>]

sadanand48 commented on code in PR #4082:
URL: https://github.com/apache/ozone/pull/4082#discussion_r1049966462


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyCreateResponse.java:
##########
@@ -91,6 +91,13 @@ public void addToDBBatch(OMMetadataManager omMetadataManager,
         omMetadataManager.getKeyTable(getBucketLayout())
             .putWithBatch(batchOperation, parentKey, parentKeyInfo);
       }
+      
+      // namespace quota changes for parent directory
+      String bucketKey = omMetadataManager.getBucketKey(
+          getOmBucketInfo().getVolumeName(),
+          getOmBucketInfo().getBucketName());
+      omMetadataManager.getBucketTable().putWithBatch(batchOperation,

Review Comment:
   Looks like the usedBytes/usedNamespace  update during key/file create was intentionally removed as part of [HDDS-6556](https://issues.apache.org/jira/browse/HDDS-6556) and the update is only upon Key commit. We should perhaps remove this.
   cc @captainzmc @errose28 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org