You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/01 04:11:22 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #17382: [improve][CI] Generate unit test code coverage reports and upload to Codecov

tisonkun commented on code in PR #17382:
URL: https://github.com/apache/pulsar/pull/17382#discussion_r960200389


##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -25,6 +25,7 @@ on:
   push:
     branches:
       - branch-*
+      - master

Review Comment:
   I don't think we should run tests for every commit on the master. If you want to generate a codecov report every day, you may schedule a daily cron job. Anyway, this is a significant change to the CI workflow.
   
   cc @codelipenghui @lhotari 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org