You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by simon <si...@wyona.com> on 2006/02/14 19:34:15 UTC
Re: svn commit: r377760
- /lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java
On Die, 2006-02-14 at 12:09 -0500, Doug Chestnut wrote:
> Hi Simon
>
> simon wrote:
> > hi doug
> >
> > i also saw this prob and i was not sure how to solve it. some ideas came
> > to my mind.
> >
> > simple but maybe not good enough:
> > there is a plugin for fckeditor called CleanUp. it cleans the code with
> > help of a javascript.
> Hmm, didn't see that. Does CleanUp require an action on the users end
> ("click a button").
yes it wouldn't be really convenient. it would require a click.
>
> One of the other problems that I have is that you only get one chance to
> save with "one form" or "fckeditor". You can page back from an error
> message, but you can't save.
maybe it would be possible to adapt bxe usecase which allows that
instead of using the oneform usecase.
>
> >
> > another maybe to sophisticated solution:
> > implementing tidy, maybe as a module.
> We could probably just use tidy in the editor usecase to clean the
> content string. This might catch other unknown problems. It would be
> nice to keep the replacement/cleanup configurable in the publication though.
i agree
simon
> >
> > but maybe your way is just the right way between this two ideas.
> Quick fix that allows me to have users give the editor a try. ;)
>
> >
> > WDYT?
> >
> > simon
> >
> >
> >
> >
> > On Die, 2006-02-14 at 16:37 +0000, chestnut@apache.org wrote:
> >
> >>Author: chestnut
> >>Date: Tue Feb 14 08:37:15 2006
> >>New Revision: 377760
> >>
> >>URL: http://svn.apache.org/viewcvs?rev=377760&view=rev
> >>Log:
> >>fckeditor seems to put allot of in the source which doesn't validate. It didn't appear that this was something
> >>configurable in the fckeditor.
> >>
> >>Modified:
> >> lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java
> >>
> >>Modified: lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java
> >>URL: http://svn.apache.org/viewcvs/lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java?rev=377760&r1=377759&r2=377760&view=diff
> >>==============================================================================
> >>--- lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java (original)
> >>+++ lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java Tue Feb 14 08:37:15 2006
> >>@@ -99,7 +99,8 @@
> >> String encoding = request.getCharacterEncoding();
> >> String content = "<?xml version=\"1.0\" encoding=\"" + encoding + "\"?>\n"
> >> + addNamespaces(namespaces, getParameterAsString("content"));
> >>-
> >>+ // ToDo: set replacements in an properties file
> >>+ content = content.replaceAll(" "," ");
> >> saveDocument(encoding, content);
> >> }
> >>
> >>
> >>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
> >>For additional commands, e-mail: commits-help@lenya.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
>
>
--
Simon Litwan simon.litwan@wyona.com
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: svn commit: r377760 - /lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java
Posted by Bob Harner <bo...@gmail.com>.
On 2/14/06, simon <si...@wyona.com> wrote:
> On Die, 2006-02-14 at 12:09 -0500, Doug Chestnut wrote:
> > Hi Simon
> >
> > simon wrote:
> > > hi doug
> > >
> > > i also saw this prob and i was not sure how to solve it. some ideas came
> > > to my mind.
> > >
> > > simple but maybe not good enough:
> > > there is a plugin for fckeditor called CleanUp. it cleans the code with
> > > help of a javascript.
> > Hmm, didn't see that. Does CleanUp require an action on the users end
> > ("click a button").
> yes it wouldn't be really convenient. it would require a click.
>
> >
> > One of the other problems that I have is that you only get one chance to
> > save with "one form" or "fckeditor". You can page back from an error
> > message, but you can't save.
> maybe it would be possible to adapt bxe usecase which allows that
> instead of using the oneform usecase.
>
> >
> > >
> > > another maybe to sophisticated solution:
> > > implementing tidy, maybe as a module.
> > We could probably just use tidy in the editor usecase to clean the
> > content string. This might catch other unknown problems. It would be
> > nice to keep the replacement/cleanup configurable in the publication though.
> i agree
>
>
> simon
> > >
> > > but maybe your way is just the right way between this two ideas.
> > Quick fix that allows me to have users give the editor a try. ;)
> >
> > >
> > > WDYT?
> > >
> > > simon
> > >
> > >
> > >
> > >
> > > On Die, 2006-02-14 at 16:37 +0000, chestnut@apache.org wrote:
> > >
> > >>Author: chestnut
> > >>Date: Tue Feb 14 08:37:15 2006
> > >>New Revision: 377760
> > >>
> > >>URL: http://svn.apache.org/viewcvs?rev=377760&view=rev
> > >>Log:
> > >>fckeditor seems to put allot of in the source which doesn't validate. It didn't appear that this was something
> > >>configurable in the fckeditor.
> > >>
> > >>Modified:
> > >> lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java
> > >>
> > >>Modified: lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java
> > >>URL: http://svn.apache.org/viewcvs/lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java?rev=377760&r1=377759&r2=377760&view=diff
> > >>==============================================================================
> > >>--- lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java (original)
> > >>+++ lenya/trunk/src/modules/fckeditor/java/src/org/apache/lenya/cms/editors/fckeditor/Fckeditor.java Tue Feb 14 08:37:15 2006
> > >>@@ -99,7 +99,8 @@
> > >> String encoding = request.getCharacterEncoding();
> > >> String content = "<?xml version=\"1.0\" encoding=\"" + encoding + "\"?>\n"
> > >> + addNamespaces(namespaces, getParameterAsString("content"));
> > >>-
> > >>+ // ToDo: set replacements in an properties file
> > >>+ content = content.replaceAll(" "," ");
> > >> saveDocument(encoding, content);
> > >> }
I believe the entities will just go away if you set
ProcessHTMLEntities to true in the configuration for FCKeditor.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org