You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/02 23:40:41 UTC
[GitHub] [ignite] sk0x50 commented on a change in pull request #7971: IGNITE-13193 Added fallback to full rebalance if historical one has f…
sk0x50 commented on a change in pull request #7971:
URL: https://github.com/apache/ignite/pull/7971#discussion_r449310976
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheOffheapManager.java
##########
@@ -1022,14 +1026,22 @@ private Metas getOrAllocateCacheMetas() throws IgniteCheckedException {
FileWALPointer minPtr = (FileWALPointer)database.checkpointHistory().searchEarliestWalPointer(grp.groupId(), partsCounters);
- WALIterator it = grp.shared().wal().replay(minPtr);
+ try {
+ WALIterator it = grp.shared().wal().replay(minPtr);
+
+ WALHistoricalIterator iterator = new WALHistoricalIterator(log, grp, partCntrs, it);
- WALHistoricalIterator iterator = new WALHistoricalIterator(log, grp, partCntrs, it);
+ // Add historical partitions which are unabled to reserve to missing set.
+ missing.addAll(iterator.missingParts);
- // Add historical partitions which are unabled to reserve to missing set.
- missing.addAll(iterator.missingParts);
+ return iterator;
+ }
+ catch (Exception ex) {
+ if (!X.hasCause(ex, IgniteHistoricalIteratorException.class))
+ throw new IgniteHistoricalIteratorException(ex);
Review comment:
It seems that everything is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org