You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "PickBas (via GitHub)" <gi...@apache.org> on 2023/02/15 12:30:07 UTC
[GitHub] [incubator-eventmesh] PickBas opened a new pull request, #3142: [ISSUE #3093] Removed redundant null checks from close()
PickBas opened a new pull request, #3142:
URL: https://github.com/apache/incubator-eventmesh/pull/3142
Fixes #3093.
### Modifications
Removed redundant if statements that were always true on lines 106, 114.
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3142: [ISSUE #3093] Removed redundant null checks from close()
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3142:
URL: https://github.com/apache/incubator-eventmesh/pull/3142#issuecomment-1431344601
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3142?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3142](https://codecov.io/gh/apache/incubator-eventmesh/pull/3142?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d93ec17) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/33584a1a4ff055ec2355b0f83045cc88d8fc79a7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33584a1) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head d93ec17 differs from pull request most recent head ae8483c. Consider uploading reports for the commit ae8483c to get more accurate results
```diff
@@ Coverage Diff @@
## master #3142 +/- ##
=========================================
Coverage 13.09% 13.09%
Complexity 1145 1145
=========================================
Files 548 548
Lines 28622 28620 -2
Branches 2849 2848 -1
=========================================
Hits 3749 3749
+ Misses 24552 24550 -2
Partials 321 321
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pl/eventmeshmessage/EventMeshMessageTCPClient.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L3RjcC9pbXBsL2V2ZW50bWVzaG1lc3NhZ2UvRXZlbnRNZXNoTWVzc2FnZVRDUENsaWVudC5qYXZh) | `9.52% <0.00%> (+0.43%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #3142: [ISSUE #3093] Removed redundant null checks from close()
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx merged PR #3142:
URL: https://github.com/apache/incubator-eventmesh/pull/3142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org