You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mi...@apache.org on 2017/01/13 02:17:50 UTC

zeppelin git commit: [ZEPPELIN-1936] Fix user impersonation setting propagation

Repository: zeppelin
Updated Branches:
  refs/heads/master 02323e283 -> 729020032


[ZEPPELIN-1936] Fix user impersonation setting propagation

### What is this PR for?
This is to fix bug of creating interpreter with impersonation enabled

### What type of PR is it?
Bug Fix

### Todos
* [x] - fix model

### What is the Jira issue?
[ZEPPELIN-1936](https://issues.apache.org/jira/browse/ZEPPELIN-1936)

### How should this be tested?
create new interpreter with "User Impersonation" enabled

### Screenshots (if appropriate)
before:
![before_imp_setting](https://cloud.githubusercontent.com/assets/1642088/21839491/e187fa18-d78c-11e6-864d-755fc40f0096.gif)

after:
![after_imp_setting](https://cloud.githubusercontent.com/assets/1642088/21839721/2756a7f0-d78e-11e6-9efd-4f3fd29df616.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Khalid Huseynov <kh...@gmail.com>

Closes #1884 from khalidhuseynov/fix/new-interp-impersonation-setting and squashes the following commits:

d5f8393 [Khalid Huseynov] fix model on interpreter-create


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/72902003
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/72902003
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/72902003

Branch: refs/heads/master
Commit: 7290200322174fa643625034af2a8c61737dad06
Parents: 02323e2
Author: Khalid Huseynov <kh...@gmail.com>
Authored: Tue Jan 10 23:22:35 2017 -0800
Committer: Mina Lee <mi...@apache.org>
Committed: Fri Jan 13 11:17:42 2017 +0900

----------------------------------------------------------------------
 .../src/app/interpreter/interpreter-create/interpreter-create.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/72902003/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
index 5d1ba67..b8e37ab 100644
--- a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
+++ b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
@@ -201,7 +201,7 @@ limitations under the License.
             <div class="checkbox remove-margin-top-bottom">
           <span class="input-group" style="line-height:30px;">
             <label>
-              <input type="checkbox" style="width:20px" ng-model="setting.option.isUserImpersonate" />
+              <input type="checkbox" style="width:20px" ng-model="newInterpreterSetting.option.isUserImpersonate" />
                 User Impersonate
             </label>
           </span>