You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/09/13 09:20:21 UTC
[GitHub] [servicecomb-java-chassis] lbc97 opened a new pull request, #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
lbc97 opened a new pull request, #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] lbc97 commented on pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
lbc97 commented on PR #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335#issuecomment-1245337038
> @lbc97 It's not in our dependency tree...
This is just a pr. Put it up first, and then ask the team leader to review whether it fits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335#issuecomment-1245296887
why do you update `org.hibernate.validator:jakarta.validation-api` I didn't see any usage of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335#issuecomment-1245334751
@lbc97 It's not in our dependency tree...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] lbc97 closed pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
lbc97 closed pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
liubao68 commented on PR #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335#issuecomment-1246131006
If we do not use `jakarta.validation-api`, we do not need to add this dependencies. Users can add it themself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] lbc97 commented on pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
lbc97 commented on PR #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335#issuecomment-1245239609
> This is a big change. Did you test it?
I have passed CI . what do you mean by test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] lbc97 commented on pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
lbc97 commented on PR #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335#issuecomment-1245300718
> why do you update `org.hibernate.validator:jakarta.validation-api` I didn't see any usage of this
https://github.com/apache/servicecomb-java-chassis/issues/3320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335#issuecomment-1245175258
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3335](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bba6a88) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/8a28acae871fb6029677ded4f96eacaac750f92d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a28aca) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3335 +/- ##
============================================
- Coverage 77.40% 77.37% -0.03%
Complexity 1452 1452
============================================
Files 1648 1648
Lines 43714 43715 +1
Branches 3675 3676 +1
============================================
- Hits 33835 33824 -11
- Misses 8350 8360 +10
- Partials 1529 1531 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | :arrow_down: |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `78.50% <0.00%> (-1.87%)` | :arrow_down: |
| [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `64.80% <0.00%> (-1.61%)` | :arrow_down: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `70.17% <0.00%> (-1.15%)` | :arrow_down: |
| [.../service/center/client/ServiceCenterDiscovery.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9zZXJ2aWNlLWNlbnRlci1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NlcnZpY2UvY2VudGVyL2NsaWVudC9TZXJ2aWNlQ2VudGVyRGlzY292ZXJ5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...comb/core/definition/MicroserviceVersionsMeta.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3335/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9kZWZpbml0aW9uL01pY3Jvc2VydmljZVZlcnNpb25zTWV0YS5qYXZh) | `100.00% <0.00%> (+5.26%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] lbc97 commented on pull request #3335: Bump jakarta.validation-api from 2.0.2 to 3.0.0
Posted by GitBox <gi...@apache.org>.
lbc97 commented on PR #3335:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3335#issuecomment-1245301875
> why do you update `org.hibernate.validator:jakarta.validation-api` I didn't see any usage of this
https://github.com/apache/servicecomb-java-chassis/issues/3320
If the customer has a requirement, upgrade it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org