You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/09/13 11:02:30 UTC
[GitHub] junichi11 commented on a change in pull request #872: Relicensed
leftover file, excluded cordova testing data
junichi11 commented on a change in pull request #872: Relicensed leftover file, excluded cordova testing data
URL: https://github.com/apache/incubator-netbeans/pull/872#discussion_r217341947
##########
File path: webcommon/cordova.platforms.ios/licenseinfo.xml
##########
@@ -21,6 +21,13 @@
-->
<licenseinfo>
<fileset>
+ <!-- Test data, should not contain comments -->
+ <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/disconnected.xml</file>
+ <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/jsoncommand.xml</file>
+ <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/listing.xml</file>
+ <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/toback.xml</file>
+ <file>cordova.platforms.ios/test/unit/src/org/netbeans/modules/cordova/platforms/ios/tofront.xml</file>
Review comment:
Paths are incorrect. I'm not sure whether `comment type="COMMENT_UNSUPPORTED"` is appropriate.
@matthiasblaesing Should we add these to [rat-exclusions.txt](https://github.com/apache/incubator-netbeans/blob/master/nbbuild/rat-exclusions.txt)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists