You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by mohammadshahidkhan <gi...@git.apache.org> on 2017/05/12 07:10:05 UTC
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/carbondata/pull/909
[CARBONDATA-1049] avoid logging raw data into driver and executor log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit d2f90fe935844720a6fae9d243cbd39fad23309c
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-05T11:13:23Z
[CARBONDATA-1027] insert into/data load failing for numeric dictionary included column having null value
commit 19a030fb2da0bb69bdf76067c82b20b77b7d4f86
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-12T07:06:42Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/909#discussion_r117235499
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
return aggType;
}
+ /**
+ * the method prepares and return the message mentioning the reason of badrecord
+ *
+ * @param columnName
+ * @param dataType
+ * @return
+ */
+ public static String prepareFailureReason(String columnName, DataType dataType) {
--- End diff --
@when number of bad records are more then for each record prepare this message will be very costly as we know the data type and column name, if bad record is enabled can we prepare this message initially and store it in some map and whenever any bad record will come we can get this message from map based on column name. For each bad record prepare this message will hit data loading speed
@kumarvishal09 what if bad record logger is enabled but no bad record present in the data.
and number of columns are bigger like 2000, is preparing map will be helpfull?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan closed the pull request at:
https://github.com/apache/carbondata/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2005/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan closed the pull request at:
https://github.com/apache/carbondata/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/909
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/909#discussion_r117213526
--- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -292,7 +292,7 @@ public static Object getDataBasedOnDataType(String data, DataType actualDataType
Date dateToStr = dateformatter.get().parse(data);
return dateToStr.getTime() * 1000;
} catch (ParseException e) {
- LOGGER.error("Cannot convert" + data + " to Time/Long type value" + e.getMessage());
+ LOGGER.error("Cannot convert value to Time/Long type value" + e.getMessage());
--- End diff --
Concatenating 2 message and logging will be better or adding two different log message will be better without newline(first message without newline)?? Because for each concatenation it will create new String object.
@ravipesala @gvramana Please comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2013/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
GitHub user mohammadshahidkhan reopened a pull request:
https://github.com/apache/carbondata/pull/909
[CARBONDATA-1049] avoid logging raw data into driver and executor log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 733c9abaee56a381056f9e284346582f236d45ca
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-12T07:06:42Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.
commit b93f7a287b3da9327bfd6a1d84249b8274cbb0d7
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-24T06:53:22Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/909#discussion_r118451182
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
return aggType;
}
+ /**
+ * the method prepares and return the message mentioning the reason of badrecord
+ *
+ * @param columnName
+ * @param dataType
+ * @return
+ */
+ public static String prepareFailureReason(String columnName, DataType dataType) {
--- End diff --
Once data loading is done or step which is handling bad record is finished map will be discarded so it is ok(Only when bad record is enabled). My intention for this comment was to create this message only once, don't create this for each bad record. Or you can do lazy creation, when you found first bad record then create the message, from next time use the same message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/909
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/202/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan closed the pull request at:
https://github.com/apache/carbondata/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
GitHub user mohammadshahidkhan reopened a pull request:
https://github.com/apache/carbondata/pull/909
[CARBONDATA-1049] avoid logging raw data into driver and executor log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 130ab740e22c9f3c57db1312d4a6bc7692eb1e62
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-12T07:06:42Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.
commit 561abbc306c2698df61879434dffa7dde88ef512
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-24T06:53:22Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2018/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
GitHub user mohammadshahidkhan reopened a pull request:
https://github.com/apache/carbondata/pull/909
[CARBONDATA-1049] avoid logging raw data into driver and executor log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 130ab740e22c9f3c57db1312d4a6bc7692eb1e62
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-12T07:06:42Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.
commit 561abbc306c2698df61879434dffa7dde88ef512
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-24T06:53:22Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan closed the pull request at:
https://github.com/apache/carbondata/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2220/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/909
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/186/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan closed the pull request at:
https://github.com/apache/carbondata/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
GitHub user mohammadshahidkhan reopened a pull request:
https://github.com/apache/carbondata/pull/909
[CARBONDATA-1049] avoid logging raw data into driver and executor log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 733c9abaee56a381056f9e284346582f236d45ca
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-12T07:06:42Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.
commit b93f7a287b3da9327bfd6a1d84249b8274cbb0d7
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-24T06:53:22Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/909
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/909
org.apache.carbondata.spark.testsuite.allqueries.InsertIntoCarbonTableTestCase.insert into carbon table from carbon table union query this randomlly failing in ci but its passing in my local.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
GitHub user mohammadshahidkhan reopened a pull request:
https://github.com/apache/carbondata/pull/909
[CARBONDATA-1049] avoid logging raw data into driver and executor log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 733c9abaee56a381056f9e284346582f236d45ca
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-12T07:06:42Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.
commit fea634f57bd8cdaf398c6614f5d61be08461a07b
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-24T06:53:22Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/909#discussion_r117212700
--- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java ---
@@ -164,7 +164,7 @@ private int getDirectSurrogateForMember(String memberStr) {
dateToStr = simpleDateFormat.parse(memberStr);
} catch (ParseException e) {
LOGGER.debug(
--- End diff --
Please add isDebugEnabled condition for debug log
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/909
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/188/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test' /><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/188/org.apache.carbondata$carbondata-spark-common-test/testReport'>carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/188/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondata.spark.testsuite.allqueries/InsertIntoCarbonTableTestCase/insert_into_carbon_table_from_carbon_table_union_query/'><strong>org.apache.carbondata.spark.testsuite.allqueries.InsertIntoCarbonTableTestCase.insert into carbon table from carbon table union query</strong></a></li></ul>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2325/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/909
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2317/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2314/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan closed the pull request at:
https://github.com/apache/carbondata/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/909#discussion_r117212427
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
return aggType;
}
+ /**
+ * the method prepares and return the message mentioning the reason of badrecord
+ *
+ * @param columnName
+ * @param dataType
+ * @return
+ */
+ public static String prepareFailureReason(String columnName, DataType dataType) {
--- End diff --
Please correct me if this is handled for each type of column already
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2130/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/909
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/192/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
GitHub user mohammadshahidkhan reopened a pull request:
https://github.com/apache/carbondata/pull/909
[CARBONDATA-1049] avoid logging raw data into driver and executor log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 130ab740e22c9f3c57db1312d4a6bc7692eb1e62
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-12T07:06:42Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.
commit 561abbc306c2698df61879434dffa7dde88ef512
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-24T06:53:22Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/909#discussion_r117211876
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
return aggType;
}
+ /**
+ * the method prepares and return the message mentioning the reason of badrecord
+ *
+ * @param columnName
+ * @param dataType
+ * @return
+ */
+ public static String prepareFailureReason(String columnName, DataType dataType) {
--- End diff --
@mohammadshahidkhan when number of bad records are more then for each record prepare this message will be very costly as we know the data type and column name, if bad record is enabled can we prepare this message initially and store it in some map and whenever any bad record will come we can get this message from map based on column name. For each bad record prepare this message will hit data loading speed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan closed the pull request at:
https://github.com/apache/carbondata/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on the issue:
https://github.com/apache/carbondata/pull/909
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/909
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/909#discussion_r117234672
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
return aggType;
}
+ /**
+ * the method prepares and return the message mentioning the reason of badrecord
+ *
+ * @param columnName
+ * @param dataType
+ * @return
+ */
+ public static String prepareFailureReason(String columnName, DataType dataType) {
--- End diff --
@kumarvishal09 it is handled for only numeric columns
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/909#discussion_r119307181
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
@@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
return aggType;
}
+ /**
+ * the method prepares and return the message mentioning the reason of badrecord
+ *
+ * @param columnName
+ * @param dataType
+ * @return
+ */
+ public static String prepareFailureReason(String columnName, DataType dataType) {
--- End diff --
@mohammadshahidkhan above review comment is handled?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Posted by mohammadshahidkhan <gi...@git.apache.org>.
GitHub user mohammadshahidkhan reopened a pull request:
https://github.com/apache/carbondata/pull/909
[CARBONDATA-1049] avoid logging raw data into driver and executor log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata logger_optimaztion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 130ab740e22c9f3c57db1312d4a6bc7692eb1e62
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-12T07:06:42Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.
commit 561abbc306c2698df61879434dffa7dde88ef512
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-05-24T06:53:22Z
[CARBONDATA-1049] Avoid logging raw data into driver and executor log.// added isDebuggEnabled check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2016/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/909
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2312/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #909: [CARBONDATA-1049] avoid logging raw data into driver ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/909
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/92/<h2>Failed Tests: <span class='status-failure'>1</span></h2><h3><a name='carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test' /><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/92/org.apache.carbondata$carbondata-spark-common-test/testReport'>carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test</a>: <span class='status-failure'>1</span></h3><ul><li><a href='https://builds.apache.org/job/carbondata-pr-spark-1.6/92/org.apache.carbondata$carbondata-spark-common-test/testReport/org.apache.carbondata.spark.testsuite.dataretention/DataRetentionConcurrencyTestCase/DataRetention_Concurrency_load_date/'><strong>org.apache.carbondata.spark.testsuite.dataretention.DataRetentionConcurrencyTestCase.DataRetention_Concurrency_load_date</strong></a></li></ul>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---