[jira] [Updated] (PHOENIX-2058) Check for existence and compatibility of columns being added in view

["Thomas D'Silva (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas D'Silva updated PHOENIX-2058:
------------------------------------
    Attachment: PHOENIX-2058-WIP.patch

[~jamestaylor]

I have attached a wip patch. I have a test that is currently failing. 
It looks like if you add a column to the base table that already exists in the the view, it still increments the column positions of the view by 1. Do you know where in the code this happens? 
This causes an exception if I try to query the view (see the test that was added).

> Check for existence and compatibility of columns being added in view
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-2058
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2058
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-2058-WIP.patch
>
>
> One check I realized we're not doing, but need to do, is ensuring that the column being added by the base table doesn't already exist in the view. If the column does already exist, ideally we can allow the addition to the base table if the type matches and the scale is null or >= existing scale and the maxLength is null or >= existing maxLength. Also, if a column is a PK column and it already exists in the view, the position in the PK must match. 
> The fact that we've materialized a PTable for the view should make the addition of this check easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)