You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by cestella <gi...@git.apache.org> on 2017/10/25 19:14:07 UTC
[GitHub] metron pull request #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of pro...
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/816
METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
## Contributor Comments
The version bump missed a couple of projects that were added between when the PR for the version bump was created and when it was committed.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-1280
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/816.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #816
----
commit cc59b7cdd3a9ef6126892645d634c3d8f2f9b91e
Author: cstella <ce...@gmail.com>
Date: 2017-10-25T19:12:33Z
METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
----
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/816
Yeah, I agree that it doesn't materially affect the example. I decided to adjust it anyway excepting the names of the rpms. Perhaps I should revert the commit. Thoughts?
---
[GitHub] metron pull request #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of pro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/816
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
Agree with @mmiklavc comment.
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/816
@cestella @mattf-horton - I don't think the commit hurts anything, so no point in removing it now that it's in. But I do agree with otto that it would be better to use $METRON_HOME and that this could be handled by a separate PR.
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
+1 by inspection, pending Travis
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/816
I agree we leave it as-is.
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/816
I just found a few more references to 0.4.1. We should probably change paths from explicit version paths to $METRON_HOME in README's. We probably don't want to tackle this here. We should fix the build first and foremost and follow up with another Jira/PR.
```
~/devprojects/metron-commits:master ✓ ➭ grep -R "0\.4\.1" --include \*.md .
./metron-analytics/metron-profiler/README.md: metron-deployment//packaging/docker/rpm-docker/RPMS/noarch/metron-profiler-0.4.1-201707131420.noarch.rpm
./metron-analytics/metron-profiler/README.md: /localrepo/metron-profiler-0.4.1-201707112313.noarch.rpm
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/bin
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/bin/start_profiler_topology.sh
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/config
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/config/profiler.properties
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/flux
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/flux/profiler
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/flux/profiler/remote.yaml
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/lib
./metron-analytics/metron-profiler/README.md: /usr/metron/0.4.1/lib/metron-profiler-0.4.1-uber.jar
./metron-analytics/metron-profiler-client/README.md:[root@node1 0.4.1]# bin/stellar -z node1:2181
```
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/816
+1 by inspection
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/816
I found a couple of refs to 0.4.1 in the profiler READMEs. I went ahead and corrected them while I was in there.
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
@mmiklavc and @cestella regarding "0.4.1" references in README.md files, please see https://github.com/apache/metron/pull/767 , specifically Otto's comment https://github.com/apache/metron/pull/767#issuecomment-332849038 and my response https://github.com/apache/metron/pull/767#issuecomment-338508550
---
[GitHub] metron issue #816: METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/816
+1 by inspection, pending Travis
---