You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2013/07/17 19:25:47 UTC
Review Request 12694: SQOOP-1139: Fix code style
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12694/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Fixed code style to match rest of the code
Diffs
-----
core/src/main/java/org/apache/sqoop/framework/JobManager.java 2d37020
Diff: https://reviews.apache.org/r/12694/diff/
Testing
-------
Ran tests - All of them passed
Thanks,
Venkat Ranganathan
Re: Review Request 12694: SQOOP-1139: Fix code style
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12694/#review23334
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On July 17, 2013, 6:47 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12694/
> -----------------------------------------------------------
>
> (Updated July 17, 2013, 6:47 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1139
> https://issues.apache.org/jira/browse/SQOOP-1139
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Fixed code style to match rest of the code
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/framework/JobManager.java 2d37020
>
> Diff: https://reviews.apache.org/r/12694/diff/
>
>
> Testing
> -------
>
> Ran tests - All of them passed
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request 12694: SQOOP-1139: Fix code style
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12694/
-----------------------------------------------------------
(Updated July 17, 2013, 6:47 p.m.)
Review request for Sqoop.
Changes
-------
Updated bug identifier
Bugs: SQOOP-1139
https://issues.apache.org/jira/browse/SQOOP-1139
Repository: sqoop-sqoop2
Description
-------
Fixed code style to match rest of the code
Diffs
-----
core/src/main/java/org/apache/sqoop/framework/JobManager.java 2d37020
Diff: https://reviews.apache.org/r/12694/diff/
Testing
-------
Ran tests - All of them passed
Thanks,
Venkat Ranganathan
Re: Review Request 12694: SQOOP-1139: Fix code style
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12694/
-----------------------------------------------------------
(Updated July 17, 2013, 6:45 p.m.)
Review request for Sqoop.
Changes
-------
Updated with cleaned up trailing blanks
Repository: sqoop-sqoop2
Description
-------
Fixed code style to match rest of the code
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/framework/JobManager.java 2d37020
Diff: https://reviews.apache.org/r/12694/diff/
Testing
-------
Ran tests - All of them passed
Thanks,
Venkat Ranganathan
Re: Review Request 12694: SQOOP-1139: Fix code style
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12694/#review23305
-----------------------------------------------------------
Thank you for taking this up Venkat! I've noticed that some of the longer lines were splitted into two lines and I was wondering if that was intentional change or some "auto-editing" tool? Otherwise please just remove the trailing whitespace characters:
core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47183>
Nit: Trailing white space character.
core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47184>
Nit: Trailing white space character.
core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47185>
Nit: Trailing white space character.
core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47186>
Nit: Trailing white space character.
core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47187>
Nit: Trailing white space character.
core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47188>
Nit: Trailing white space character.
core/src/main/java/org/apache/sqoop/framework/JobManager.java
<https://reviews.apache.org/r/12694/#comment47189>
Nit: Trailing white space character.
Jarcec
- Jarek Cecho
On July 17, 2013, 5:25 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12694/
> -----------------------------------------------------------
>
> (Updated July 17, 2013, 5:25 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Fixed code style to match rest of the code
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/framework/JobManager.java 2d37020
>
> Diff: https://reviews.apache.org/r/12694/diff/
>
>
> Testing
> -------
>
> Ran tests - All of them passed
>
>
> Thanks,
>
> Venkat Ranganathan
>
>