You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/16 07:02:23 UTC
[GitHub] [pulsar] liudezhi2098 opened a new pull request #13772: Fix checkstyle bookieRackAffinityMapping error in pulsar-ci-test
liudezhi2098 opened a new pull request #13772:
URL: https://github.com/apache/pulsar/pull/13772
Motivation
fix checkstyle bookieRackAffinityMapping error in pulsar-ci-test (group2)
Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #13772: [ pulsar-ci-test] Fix checkstyle bookieRackAffinityMapping error
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #13772:
URL: https://github.com/apache/pulsar/pull/13772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #13772: [ pulsar-ci-test] Fix checkstyle bookieRackAffinityMapping error
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #13772:
URL: https://github.com/apache/pulsar/pull/13772#issuecomment-1013827135
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on pull request #13772: [ pulsar-ci-test] Fix checkstyle bookieRackAffinityMapping error
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on pull request #13772:
URL: https://github.com/apache/pulsar/pull/13772#issuecomment-1013833168
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on pull request #13772: [ pulsar-ci-test] Fix checkstyle bookieRackAffinityMapping error
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on pull request #13772:
URL: https://github.com/apache/pulsar/pull/13772#issuecomment-1014231479
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on pull request #13772: [ pulsar-ci-test] Fix checkstyle bookieRackAffinityMapping error
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on pull request #13772:
URL: https://github.com/apache/pulsar/pull/13772#issuecomment-1014154249
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #13772: [ pulsar-ci-test] Fix checkstyle bookieRackAffinityMapping error
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #13772:
URL: https://github.com/apache/pulsar/pull/13772#issuecomment-1013827135
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #13772: [ pulsar-ci-test] Fix checkstyle bookieRackAffinityMapping error
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #13772:
URL: https://github.com/apache/pulsar/pull/13772#discussion_r785593742
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/BookieRackAffinityMapping.java
##########
@@ -161,7 +161,7 @@ private String getRack(String bookieAddress) {
}
if (bi != null
- && !Strings.isNullOrEmpty(bi.getRack())
+ && !com.google.api.client.util.Strings.isNullOrEmpty(bi.getRack())
Review comment:
I think we can use "org.apache.commons.lang3.StringUtils#isEmpty" to avoid this checkstyle issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org