Re: [PR] Fix concurrency issues in Azure credential refresh. [iceberg]

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #13730:
URL: https://github.com/apache/iceberg/pull/13730#discussion_r2253977835


##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java:
##########
@@ -51,7 +52,7 @@ public class VendedAdlsCredentialProvider implements Serializable, AutoCloseable
   private final SerializableMap<String, String> properties;
   private final String credentialsEndpoint;
   private final String catalogEndpoint;
-  private transient volatile Map<String, SimpleTokenCache> sasCredentialByAccount;
+  private transient volatile ConcurrentMap<String, SimpleTokenCache> sasCredentialByAccount;

Review Comment:
   ```suggestion
     private transient volatile Map<String, SimpleTokenCache> sasCredentialByAccount;
   ```
   
   this can still stay a Map



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org