[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1774: SOLR-14774: Create HealthCheckHandler in CoreContainer

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #1774:
URL: https://github.com/apache/lucene-solr/pull/1774#discussion_r475556783



##########
File path: solr/core/src/java/org/apache/solr/handler/admin/InfoHandler.java
##########
@@ -50,7 +50,10 @@ public InfoHandler(final CoreContainer coreContainer) {
     handlers.put("properties", new PropertiesRequestHandler());
     handlers.put("logging", new LoggingHandler(coreContainer));
     handlers.put("system", new SystemInfoHandler(coreContainer));
-    handlers.put("health", new HealthCheckHandler(coreContainer));
+    if (coreContainer.getHealthCheckHandler() == null) {
+      throw new IllegalStateException("HealthCheckHandler needs to be initialized before creating InfoHandler");

Review comment:
       > `throw new IllegalStateException("HealthCheckHandler needs to be initialized before creating InfoHandler");`
   
   How about also having a "HealthCheckHandler then InfoHandler order matters because ..." style comment in `CoreContainer`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org