You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "erenavsarogullari (via GitHub)" <gi...@apache.org> on 2024/03/31 05:19:35 UTC

[PR] Move `Radians`, `Signum`, `Sin`, `Sinh`, `Sqrt` functions to `datafusion-functions` crate [arrow-datafusion]

erenavsarogullari opened a new pull request, #9882:
URL: https://github.com/apache/arrow-datafusion/pull/9882

   ## Which issue does this PR close?
   Closes #9860.
   
   ## What changes are included in this PR?
   `radians`, `signum`, `sin`, `sinh` and `sqrt` functions are moved to `datafusion-functions` crate.
   
   ## Are these changes tested?
   Yes, all `scalar.slt` based `radians`, `signum`, `sin`, `sinh` and `sqrt` functions' tests are passed.
   
   ## Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move `radians`, `signum`, `sin`, `sinh` and `sqrt` functions to `datafusion-functions` crate [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9882:
URL: https://github.com/apache/arrow-datafusion/pull/9882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move `radians`, `signum`, `sin`, `sinh` and `sqrt` functions to `datafusion-functions` crate [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9882:
URL: https://github.com/apache/arrow-datafusion/pull/9882#issuecomment-2032718716

   🚀  -- thanks @Weijun-H  and @erenavsarogullari ❤️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move `radians`, `signum`, `sin`, `sinh` and `sqrt` functions to `datafusion-functions` crate [arrow-datafusion]

Posted by "erenavsarogullari (via GitHub)" <gi...@apache.org>.
erenavsarogullari commented on PR #9882:
URL: https://github.com/apache/arrow-datafusion/pull/9882#issuecomment-2031071553

   Thanks for the review. CI failure has been addressed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move `radians`, `signum`, `sin`, `sinh` and `sqrt` functions to `datafusion-functions` crate [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9882:
URL: https://github.com/apache/arrow-datafusion/pull/9882#issuecomment-2030106868

   🤔  there seems to be one more CI failure related to this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Move `radians`, `signum`, `sin`, `sinh` and `sqrt` functions to `datafusion-functions` crate [arrow-datafusion]

Posted by "erenavsarogullari (via GitHub)" <gi...@apache.org>.
erenavsarogullari commented on PR #9882:
URL: https://github.com/apache/arrow-datafusion/pull/9882#issuecomment-2029035844

   Current test failures due to #9891 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org