You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2022/04/25 05:33:49 UTC
[GitHub] [openmeetings] sebawagner opened a new pull request, #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
sebawagner opened a new pull request, #176:
URL: https://github.com/apache/openmeetings/pull/176
Update KMS docu
And update banner. The trick with event-current as URL and image doesn't work anymore. I would suggest for now just put the image in. And we have till October to change the banner again (or somebody fixes the current-event URL)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a diff in pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on code in PR #176:
URL: https://github.com/apache/openmeetings/pull/176#discussion_r857270269
##########
openmeetings-server/src/site/resources/js/site.js:
##########
@@ -27,7 +27,7 @@ $(document).ready(function() {
$('.header .bannerRight').parent().append(
$('<div class="float-right">')
.append($('<a href="https://www.apache.org/events/current-event" class="apachecon-banner bannerRight">')
- .append($('<img src="https://www.apache.org/events/current-event-234x60.png">'))
Review Comment:
This URL doesn't work anymore. It points to the old website and image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #176:
URL: https://github.com/apache/openmeetings/pull/176#issuecomment-1109425577
Well
I guess planners are busy preparing ACNA2022 this is why https://www.apache.org/events/current-event-234x60.png is not (yet) updated
The idea of this shortcut is to provide projects with the constant ApacheCon banner
so there will be no need to update 200+ sites 2 times per year
I ask to update the banner image :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #176:
URL: https://github.com/apache/openmeetings/pull/176#issuecomment-1109242927
Well,
there is ASF wide policy of what need to included to the site
And it's being automatically checked
By this tool: https://whimsy.apache.org/site/project/openmeetings
I'm afraid these PR should be rejected :((
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a diff in pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on code in PR #176:
URL: https://github.com/apache/openmeetings/pull/176#discussion_r857313155
##########
openmeetings-server/src/site/resources/js/site.js:
##########
@@ -27,7 +27,7 @@ $(document).ready(function() {
$('.header .bannerRight').parent().append(
$('<div class="float-right">')
.append($('<a href="https://www.apache.org/events/current-event" class="apachecon-banner bannerRight">')
- .append($('<img src="https://www.apache.org/events/current-event-234x60.png">'))
Review Comment:
@solomax happy with that? We can fix it once/if current-event image URL starts working again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a diff in pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on code in PR #176:
URL: https://github.com/apache/openmeetings/pull/176#discussion_r857270136
##########
openmeetings-server/src/site/xdoc/index.xml:
##########
@@ -139,8 +139,8 @@
<div class="row">
<div class="col-md-1"></div>
<div class="col-md-8">
- <a href="https://www.apache.org/events/current-event">
- <img alt="ASF Current Events" src="https://www.apache.org/events/current-event-234x60.png"/>
+ <a href="https://apachecon.com/">
Review Comment:
The links seem to simply now point to the ApacheCon website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #176:
URL: https://github.com/apache/openmeetings/pull/176#issuecomment-1110694631
@sebawagner banner is fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on PR #176:
URL: https://github.com/apache/openmeetings/pull/176#issuecomment-1109369245
> https://whimsy.apache.org/site/project/openmeetings
The check should be still green since we link to: https://www.apache.org/events/current-event
Which is the same for other projects that are green, see: https://whimsy.apache.org/site/check/events
The only thing that we change is the image URL. Not the link target. And the image URL seems broken/unmaintained.
So those checks should be fine. And ourself will still be compliant to the ASF policy.
Assuming those checks and links are fine we should be able to merge @solomax Otherwise I can fix it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a diff in pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on code in PR #176:
URL: https://github.com/apache/openmeetings/pull/176#discussion_r858299735
##########
openmeetings-server/src/site/resources/js/site.js:
##########
@@ -27,7 +27,7 @@ $(document).ready(function() {
$('.header .bannerRight').parent().append(
$('<div class="float-right">')
.append($('<a href="https://www.apache.org/events/current-event" class="apachecon-banner bannerRight">')
- .append($('<img src="https://www.apache.org/events/current-event-234x60.png">'))
Review Comment:
Maybe Im misleading here, but the link target is still the same: https://www.apache.org/events/current-event
I have just updated the image URL, since that one doesn't seem to work anymore.
So whimsy should be still correct and pass:https://whimsy.apache.org/site/check/events
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a diff in pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on code in PR #176:
URL: https://github.com/apache/openmeetings/pull/176#discussion_r857270136
##########
openmeetings-server/src/site/xdoc/index.xml:
##########
@@ -139,8 +139,8 @@
<div class="row">
<div class="col-md-1"></div>
<div class="col-md-8">
- <a href="https://www.apache.org/events/current-event">
- <img alt="ASF Current Events" src="https://www.apache.org/events/current-event-234x60.png"/>
+ <a href="https://apachecon.com/">
Review Comment:
The links seem to simply now point to the ApacheCon website in the public docs @apache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner closed pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
sebawagner closed pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
URL: https://github.com/apache/openmeetings/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
sebawagner commented on PR #176:
URL: https://github.com/apache/openmeetings/pull/176#issuecomment-1109447697
Okay lets wait. But I think its ugly. The image banner is broken since September 2021. Since then the image is outdated. And our website looks like outdated/stale since September 2021. We should remove update or fix those image banners or find some other work around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #176:
URL: https://github.com/apache/openmeetings/pull/176#issuecomment-1109495243
@sebawagner here is the process of having up-to-date banner for ApacheCon https://www.apachecon.com/event-images/
I'll ping https://whimsy.apache.org/ so they will update the tool :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #176: OPENMEETINGS-2728 Update KMS docu and apachecon banner.
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #176:
URL: https://github.com/apache/openmeetings/pull/176#issuecomment-1109450766
@sebawagner other changes LGTM to me :)
I believe the image will be updated shortly
so please keep other changes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org