You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/26 13:33:50 UTC
Review Request 67742: Allowed SOME principal in ACLs for new destroy
operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67742/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Bugs: MESOS-7329
https://issues.apache.org/jira/browse/MESOS-7329
Repository: mesos
Description
-------
This patch adds support for controlling the principals of disk
resources a local authorizer subject is allowed to work on with
`DESTROY_MOUNT` and `DESTROY_BLOCK` operations.
Diffs
-----
src/authorizer/local/authorizer.cpp 61e9ab5ce9f1ce4eee4a3f8502c9b60140efcb7e
src/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60
Diff: https://reviews.apache.org/r/67742/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 67742: Allowed SOME principal in ACLs for new
destroy operations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67742/#review205377
-----------------------------------------------------------
PASS: Mesos patch 67742 was successfully built and tested.
Reviews applied: `['67501', '67723', '67724', '67725', '67742']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67742
- Mesos Reviewbot Windows
On June 26, 2018, 2:13 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67742/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 2:13 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-7329
> https://issues.apache.org/jira/browse/MESOS-7329
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds support for controlling the principals of disk
> resources a local authorizer subject is allowed to work on with
> `DESTROY_MOUNT` and `DESTROY_BLOCK` operations.
>
>
> Diffs
> -----
>
> docs/authorization.md cd8622b9848b7a020c079cc1901e3933fa6eb0c0
> include/mesos/authorizer/acls.proto e4889939481dabe6c1c2876a54d654f98d00dec8
> src/authorizer/local/authorizer.cpp 61e9ab5ce9f1ce4eee4a3f8502c9b60140efcb7e
> src/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60
>
>
> Diff: https://reviews.apache.org/r/67742/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67742: Allowed SOME principal in ACLs for new
destroy operations.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67742/#review205390
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67501, 67723, 67724, 67725, 67742]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 26, 2018, 7:13 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67742/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 7:13 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-7329
> https://issues.apache.org/jira/browse/MESOS-7329
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds support for controlling the principals of disk
> resources a local authorizer subject is allowed to work on with
> `DESTROY_MOUNT` and `DESTROY_BLOCK` operations.
>
>
> Diffs
> -----
>
> docs/authorization.md cd8622b9848b7a020c079cc1901e3933fa6eb0c0
> include/mesos/authorizer/acls.proto e4889939481dabe6c1c2876a54d654f98d00dec8
> src/authorizer/local/authorizer.cpp 61e9ab5ce9f1ce4eee4a3f8502c9b60140efcb7e
> src/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60
>
>
> Diff: https://reviews.apache.org/r/67742/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67742: Allowed SOME principal in ACLs for new
destroy operations.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67742/
-----------------------------------------------------------
(Updated June 26, 2018, 4:13 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Bugs: MESOS-7329
https://issues.apache.org/jira/browse/MESOS-7329
Repository: mesos
Description
-------
This patch adds support for controlling the principals of disk
resources a local authorizer subject is allowed to work on with
`DESTROY_MOUNT` and `DESTROY_BLOCK` operations.
Diffs (updated)
-----
docs/authorization.md cd8622b9848b7a020c079cc1901e3933fa6eb0c0
include/mesos/authorizer/acls.proto e4889939481dabe6c1c2876a54d654f98d00dec8
src/authorizer/local/authorizer.cpp 61e9ab5ce9f1ce4eee4a3f8502c9b60140efcb7e
src/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60
Diff: https://reviews.apache.org/r/67742/diff/2/
Changes: https://reviews.apache.org/r/67742/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier