You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/15 03:24:02 UTC
[GitHub] [dubbo] BurningCN opened a new pull request #9275: Optimize the code for a qos module and add unit test
BurningCN opened a new pull request #9275:
URL: https://github.com/apache/dubbo/pull/9275
## What is the purpose of the change
- Add and fix some unit tests
- FullHttpRequest/FullHttpResponse replaces deprecated methods (such as getUri()->uri())
- Use ArrayUtils to check if the array is empty and StringUtils to check if the string is empty
- Fix typo and comments
- Cache the parsed result of the HelpCommand and HelpTelnetHandler #7919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #9275: Optimize the code for a qos module and add unit test
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9275:
URL: https://github.com/apache/dubbo/pull/9275#issuecomment-968521002
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9275?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9275](https://codecov.io/gh/apache/dubbo/pull/9275?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec43a69) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bfef39bbc183fd7ceab638aa7b0c244a65b0210d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfef39b) will **increase** coverage by `0.13%`.
> The diff coverage is `82.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/9275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9275 +/- ##
============================================
+ Coverage 64.96% 65.09% +0.13%
- Complexity 328 329 +1
============================================
Files 1206 1206
Lines 51799 51843 +44
Branches 7725 7714 -11
============================================
+ Hits 33650 33747 +97
+ Misses 14515 14475 -40
+ Partials 3634 3621 -13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/dubbo/qos/command/impl/OfflineApp.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9PZmZsaW5lQXBwLmphdmE=) | `80.00% <ø> (+30.00%)` | :arrow_up: |
| [...java/org/apache/dubbo/qos/command/impl/Online.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9PbmxpbmUuamF2YQ==) | `100.00% <ø> (+50.00%)` | :arrow_up: |
| [...g/apache/dubbo/qos/command/util/CommandHelper.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvdXRpbC9Db21tYW5kSGVscGVyLmphdmE=) | `94.44% <ø> (-0.30%)` | :arrow_down: |
| [...org/apache/dubbo/qos/command/impl/BaseOffline.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9CYXNlT2ZmbGluZS5qYXZh) | `84.37% <50.00%> (+71.87%)` | :arrow_up: |
| [.../dubbo/qos/command/decoder/HttpCommandDecoder.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvZGVjb2Rlci9IdHRwQ29tbWFuZERlY29kZXIuamF2YQ==) | `73.52% <66.66%> (ø)` | |
| [...ting/telnet/support/command/HelpTelnetHandler.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90ZWxuZXQvc3VwcG9ydC9jb21tYW5kL0hlbHBUZWxuZXRIYW5kbGVyLmphdmE=) | `77.41% <74.07%> (+2.41%)` | :arrow_up: |
| [...n/java/org/apache/dubbo/qos/command/impl/Live.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9MaXZlLmphdmE=) | `95.65% <88.88%> (+83.15%)` | :arrow_up: |
| [...pache/dubbo/qos/command/CommandContextFactory.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvQ29tbWFuZENvbnRleHRGYWN0b3J5LmphdmE=) | `66.66% <100.00%> (ø)` | |
| [...rg/apache/dubbo/qos/command/impl/ChangeTelnet.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9DaGFuZ2VUZWxuZXQuamF2YQ==) | `92.30% <100.00%> (+3.84%)` | :arrow_up: |
| [...org/apache/dubbo/qos/command/impl/CountTelnet.java](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9Db3VudFRlbG5ldC5qYXZh) | `57.73% <100.00%> (-0.44%)` | :arrow_down: |
| ... and [68 more](https://codecov.io/gh/apache/dubbo/pull/9275/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9275?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9275?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bfef39b...ec43a69](https://codecov.io/gh/apache/dubbo/pull/9275?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #9275: Optimize the code for a qos module and add unit test
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9275:
URL: https://github.com/apache/dubbo/pull/9275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org