You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by sk...@apache.org on 2018/07/16 22:38:23 UTC

[incubator-mxnet] branch master updated: onnx split op import (#11593)

This is an automated email from the ASF dual-hosted git repository.

skm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git


The following commit(s) were added to refs/heads/master by this push:
     new e70f6ff  onnx split op import (#11593)
e70f6ff is described below

commit e70f6ff51a30afd4b8d4afa6f281e9f95453bb4f
Author: Roshani Nagmote <ro...@gmail.com>
AuthorDate: Mon Jul 16 15:38:14 2018 -0700

    onnx split op import (#11593)
    
    * split operator import modified
    
    * split test cases partially enabled
    
    * lint fix
    
    * issue linked from error message
---
 python/mxnet/contrib/onnx/onnx2mx/_op_translations.py | 14 ++++++++++++++
 tests/python-pytest/onnx/import/mxnet_backend_rep.py  |  3 +++
 tests/python-pytest/onnx/import/test_cases.py         |  1 +
 3 files changed, 18 insertions(+)

diff --git a/python/mxnet/contrib/onnx/onnx2mx/_op_translations.py b/python/mxnet/contrib/onnx/onnx2mx/_op_translations.py
index 61f342a..aa37856 100644
--- a/python/mxnet/contrib/onnx/onnx2mx/_op_translations.py
+++ b/python/mxnet/contrib/onnx/onnx2mx/_op_translations.py
@@ -409,8 +409,22 @@ def cast(attrs, inputs, proto_obj):
 
 def split(attrs, inputs, proto_obj):
     """Splits an array along a particular axis into multiple sub-arrays."""
+    split_list = attrs.get('split') if 'split' in attrs else []
     new_attrs = translation_utils._fix_attribute_names(attrs,
                                                        {'split' : 'num_outputs'})
+    if 'axis' not in attrs:
+        new_attrs = translation_utils._add_extra_attributes(new_attrs, {'axis': 0})
+
+    if not split_list:
+        num_outputs = len(proto_obj.model_metadata.get('output_tensor_data'))
+    else:
+        raise NotImplementedError("Operator {} in MXNet does not support variable splits."
+                                  "Tracking the issue to support variable split here: "
+                                  "https://github.com/apache/incubator-mxnet/issues/11594"
+                                  .format('split'))
+
+    new_attrs['num_outputs'] = num_outputs
+
     return 'split', new_attrs, inputs
 
 def _slice(attrs, inputs, proto_obj):
diff --git a/tests/python-pytest/onnx/import/mxnet_backend_rep.py b/tests/python-pytest/onnx/import/mxnet_backend_rep.py
index 067ef15..31a1935 100644
--- a/tests/python-pytest/onnx/import/mxnet_backend_rep.py
+++ b/tests/python-pytest/onnx/import/mxnet_backend_rep.py
@@ -82,4 +82,7 @@ class MXNetBackendRep(BackendRep):
         # run inference
         mod.forward(mx.io.DataBatch(data_forward))
         result = mod.get_outputs()[0].asnumpy()
+        # split operator inference returns 1 less dimension
+        if self.symbol.name.startswith('split'):
+            return [i.asnumpy() for i in mod.get_outputs()]
         return [result]
diff --git a/tests/python-pytest/onnx/import/test_cases.py b/tests/python-pytest/onnx/import/test_cases.py
index 24265bd..d2574db 100644
--- a/tests/python-pytest/onnx/import/test_cases.py
+++ b/tests/python-pytest/onnx/import/test_cases.py
@@ -18,6 +18,7 @@
 """Test Cases to be run for the import module"""
 
 IMPLEMENTED_OPERATORS_TEST = [
+    'test_split_equal'
     'test_random_uniform',
     'test_random_normal',
     'test_add',