You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/22 00:12:03 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #7760: Update ttl.md to add another 2 types of model relating to recordTTL
wu-sheng opened a new pull request #7760:
URL: https://github.com/apache/skywalking/pull/7760
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7760: Update ttl.md to add another 2 types of model relating to recordTTL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7760:
URL: https://github.com/apache/skywalking/pull/7760#discussion_r713514268
##########
File path: docs/en/setup/backend/ttl.md
##########
@@ -1,7 +1,7 @@
# TTL
-In SkyWalking, besides metadata, there are two types of observability data:
-1. Record: Includes trace and alarm. Log may also be included in the future.
-1. Metric: Includes percentile, heat map, success rate, cpm (rpm), etc.
+In SkyWalking, there are two types of observability data:
Review comment:
The summary is "two types of data" but the list items are two types of TTL, I think it's mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7760: Update ttl.md to add another 2 types of model relating to recordTTL
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7760:
URL: https://github.com/apache/skywalking/pull/7760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7760: Update ttl.md to add another 2 types of model relating to recordTTL
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7760:
URL: https://github.com/apache/skywalking/pull/7760#discussion_r713515116
##########
File path: docs/en/setup/backend/ttl.md
##########
@@ -1,7 +1,7 @@
# TTL
-In SkyWalking, besides metadata, there are two types of observability data:
-1. Record: Includes trace and alarm. Log may also be included in the future.
-1. Metric: Includes percentile, heat map, success rate, cpm (rpm), etc.
+In SkyWalking, there are two types of observability data:
Review comment:
Reword them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org