You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/21 20:56:19 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27644:
[SPARK-30868][SQL] Throw Exception if runHive(sql) failed
dongjoon-hyun commented on a change in pull request #27644: [SPARK-30868][SQL] Throw Exception if runHive(sql) failed
URL: https://github.com/apache/spark/pull/27644#discussion_r382801656
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -839,7 +839,12 @@ private[hive] class HiveClientImpl(
state.out.println(tokens(0) + " " + cmd_1)
// scalastyle:on println
}
- Seq(proc.run(cmd_1).getResponseCode.toString)
+ val response: CommandProcessorResponse = proc.run(cmd)
Review comment:
This should be `cmd_1` instead of `cmd`. Is there a reason to use `cmd`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org