[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1178: [CELEBORN-237][IMPROVEMENT] push failed error message should show partition info

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1178:
URL: https://github.com/apache/incubator-celeborn/pull/1178#discussion_r1089670215


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -423,7 +427,9 @@ class PushDataHandler extends BaseMessageHandler with Logging {
         } else {
           StatusCode.PUSH_DATA_FAIL_SLAVE.getMessage()
         }
-      callback.onFailure(new Exception(message, exception))
+      callback.onFailure(new Exception(
+        s"$message! ${locations.map(_.toString).mkString("{", ", ", "}")}",

Review Comment:
   If the purpose is to log the worker location, then it's unnecessary to print out all locations here, since they all belong the the same worker. Maybe locations.head is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org