You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/26 05:27:03 UTC

[GitHub] [spark] HeartSaVioR commented on issue #27010: [SPARK-30313][CORE] Ensure EndpointRef is available MasterWebUI/WorkerPage

HeartSaVioR commented on issue #27010: [SPARK-30313][CORE] Ensure EndpointRef is available MasterWebUI/WorkerPage
URL: https://github.com/apache/spark/pull/27010#issuecomment-568973827
 
 
   Hmm... Does it mean the comment in below is broken? The code comment says `self` will become valid when `onStart` is called, but that doesn't seem to be true - self will become valid "around" when onStart is called and there's no guarantee that self is valid in onStart.
   
   https://github.com/apache/spark/blob/481fb63f97d87d5b2e9e1f9b30bee466605b5a72/core/src/main/scala/org/apache/spark/rpc/RpcEndpoint.scala#L53-L63

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org