You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Daniel Dai <da...@gmail.com> on 2018/05/11 21:55:40 UTC
Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer work
with information schema
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67102/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
See HIVE-19440
Diffs
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/storagehandler/DummyHCatAuthProvider.java a53028f
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestHDFSPermissionPolicyProvider.java PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/ql/security/DummyHiveMetastoreAuthorizationProvider.java 31e795c
metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql d9606d8
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4611ce9
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HDFSPermissionPolicyProvider.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveAuthorizationProviderBase.java 8a7c06d
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveMetastoreAuthorizationProvider.java 0dab334
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PolicyProviderContainer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java 9b2e6cd
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java b66d188
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 48798d8
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 02ed7aa
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentAuthorizer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java 3eb0914
service/src/java/org/apache/hive/service/server/HiveServer2.java cf3edbf
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 3978b88
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 6af2aa5
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 09f9bb1
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java b43334b
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java ce7d286
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java b223920
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/HiveObjectPrivilegeBuilder.java d802e1a
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MDBPrivilege.java 3d8fa21
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MGlobalPrivilege.java 5b496e0
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionColumnPrivilege.java ab50a92
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionPrivilege.java 3193bc1
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTableColumnPrivilege.java ad7322f
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTablePrivilege.java 6460400
standalone-metastore/src/main/resources/package.jdo 2d2cb19
standalone-metastore/src/main/sql/derby/hive-schema-3.0.0.derby.sql 8e09755
standalone-metastore/src/main/sql/derby/upgrade-2.3.0-to-3.0.0.derby.sql 73bef36
standalone-metastore/src/main/sql/mssql/hive-schema-3.0.0.mssql.sql 51df92c
standalone-metastore/src/main/sql/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql a7232dd
standalone-metastore/src/main/sql/mysql/hive-schema-3.0.0.mysql.sql 8e55e94
standalone-metastore/src/main/sql/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 9a48346
standalone-metastore/src/main/sql/oracle/hive-schema-3.0.0.oracle.sql 3a12e08
standalone-metastore/src/main/sql/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 3be7e65
standalone-metastore/src/main/sql/postgres/hive-schema-3.0.0.postgres.sql 0152f48
standalone-metastore/src/main/sql/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql fed8a93
standalone-metastore/src/main/thrift/hive_metastore.thrift 19d4433
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f6899be
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 98a85cc
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 7186add
Diff: https://reviews.apache.org/r/67102/diff/1/
Testing
-------
Thanks,
Daniel Dai
Re: Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer
work with information schema
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67102/#review203274
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On May 15, 2018, 9:04 p.m., Daniel Dai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67102/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 9:04 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See HIVE-19440
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/storagehandler/DummyHCatAuthProvider.java a53028f
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestHDFSPermissionPolicyProvider.java PRE-CREATION
> itests/util/src/main/java/org/apache/hadoop/hive/ql/security/DummyHiveMetastoreAuthorizationProvider.java 31e795c
> metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql d9606d8
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java a1f549a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HDFSPermissionPolicyProvider.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveAuthorizationProviderBase.java 8a7c06d
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveMetastoreAuthorizationProvider.java 0dab334
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PolicyProviderContainer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java 9b2e6cd
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java b66d188
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 48798d8
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 02ed7aa
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentAuthorizer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java 3eb0914
> service/src/java/org/apache/hive/service/server/HiveServer2.java 661beb5
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 92d2e3f
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 6af2aa5
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 09f9bb1
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 264fdb9
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java ce7d286
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java b223920
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/HiveObjectPrivilegeBuilder.java d802e1a
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MDBPrivilege.java 3d8fa21
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MGlobalPrivilege.java 5b496e0
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionColumnPrivilege.java ab50a92
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionPrivilege.java 3193bc1
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTableColumnPrivilege.java ad7322f
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTablePrivilege.java 6460400
> standalone-metastore/src/main/resources/package.jdo 2d2cb19
> standalone-metastore/src/main/sql/derby/hive-schema-3.1.0.derby.sql PRE-CREATION
> standalone-metastore/src/main/sql/derby/upgrade-3.0.0-to-3.1.0.derby.sql PRE-CREATION
> standalone-metastore/src/main/sql/mssql/hive-schema-3.1.0.mssql.sql PRE-CREATION
> standalone-metastore/src/main/sql/mssql/upgrade-3.0.0-to-3.1.0.mssql.sql PRE-CREATION
> standalone-metastore/src/main/sql/mysql/hive-schema-3.1.0.mysql.sql PRE-CREATION
> standalone-metastore/src/main/sql/mysql/upgrade-3.0.0-to-3.1.0.mysql.sql PRE-CREATION
> standalone-metastore/src/main/sql/oracle/hive-schema-3.1.0.oracle.sql PRE-CREATION
> standalone-metastore/src/main/sql/oracle/upgrade-3.0.0-to-3.1.0.oracle.sql PRE-CREATION
> standalone-metastore/src/main/sql/postgres/hive-schema-3.1.0.postgres.sql PRE-CREATION
> standalone-metastore/src/main/sql/postgres/upgrade-3.0.0-to-3.1.0.postgres.sql PRE-CREATION
> standalone-metastore/src/main/thrift/hive_metastore.thrift 19d4433
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f6899be
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 98a85cc
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 7186add
>
>
> Diff: https://reviews.apache.org/r/67102/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Dai
>
>
Re: Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer
work with information schema
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67102/#review203070
-----------------------------------------------------------
service/src/java/org/apache/hive/service/server/HiveServer2.java
Lines 992 (patched)
<https://reviews.apache.org/r/67102/#comment285140>
how about using AuthorizationPreEventListener.class.getName() or so ?
- Thejas Nair
On May 15, 2018, 9:04 p.m., Daniel Dai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67102/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 9:04 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See HIVE-19440
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/storagehandler/DummyHCatAuthProvider.java a53028f
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestHDFSPermissionPolicyProvider.java PRE-CREATION
> itests/util/src/main/java/org/apache/hadoop/hive/ql/security/DummyHiveMetastoreAuthorizationProvider.java 31e795c
> metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql d9606d8
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java a1f549a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HDFSPermissionPolicyProvider.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveAuthorizationProviderBase.java 8a7c06d
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveMetastoreAuthorizationProvider.java 0dab334
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PolicyProviderContainer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java 9b2e6cd
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java b66d188
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 48798d8
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 02ed7aa
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentAuthorizer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java 3eb0914
> service/src/java/org/apache/hive/service/server/HiveServer2.java 661beb5
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 92d2e3f
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 6af2aa5
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 09f9bb1
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 264fdb9
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java ce7d286
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java b223920
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/HiveObjectPrivilegeBuilder.java d802e1a
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MDBPrivilege.java 3d8fa21
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MGlobalPrivilege.java 5b496e0
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionColumnPrivilege.java ab50a92
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionPrivilege.java 3193bc1
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTableColumnPrivilege.java ad7322f
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTablePrivilege.java 6460400
> standalone-metastore/src/main/resources/package.jdo 2d2cb19
> standalone-metastore/src/main/sql/derby/hive-schema-3.1.0.derby.sql PRE-CREATION
> standalone-metastore/src/main/sql/derby/upgrade-3.0.0-to-3.1.0.derby.sql PRE-CREATION
> standalone-metastore/src/main/sql/mssql/hive-schema-3.1.0.mssql.sql PRE-CREATION
> standalone-metastore/src/main/sql/mssql/upgrade-3.0.0-to-3.1.0.mssql.sql PRE-CREATION
> standalone-metastore/src/main/sql/mysql/hive-schema-3.1.0.mysql.sql PRE-CREATION
> standalone-metastore/src/main/sql/mysql/upgrade-3.0.0-to-3.1.0.mysql.sql PRE-CREATION
> standalone-metastore/src/main/sql/oracle/hive-schema-3.1.0.oracle.sql PRE-CREATION
> standalone-metastore/src/main/sql/oracle/upgrade-3.0.0-to-3.1.0.oracle.sql PRE-CREATION
> standalone-metastore/src/main/sql/postgres/hive-schema-3.1.0.postgres.sql PRE-CREATION
> standalone-metastore/src/main/sql/postgres/upgrade-3.0.0-to-3.1.0.postgres.sql PRE-CREATION
> standalone-metastore/src/main/thrift/hive_metastore.thrift 19d4433
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f6899be
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 98a85cc
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 7186add
>
>
> Diff: https://reviews.apache.org/r/67102/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Dai
>
>
Re: Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer
work with information schema
Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67102/
-----------------------------------------------------------
(Updated May 15, 2018, 9:04 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
See HIVE-19440
Diffs (updated)
-----
hcatalog/core/src/main/java/org/apache/hive/hcatalog/storagehandler/DummyHCatAuthProvider.java a53028f
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestHDFSPermissionPolicyProvider.java PRE-CREATION
itests/util/src/main/java/org/apache/hadoop/hive/ql/security/DummyHiveMetastoreAuthorizationProvider.java 31e795c
metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql d9606d8
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java a1f549a
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HDFSPermissionPolicyProvider.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveAuthorizationProviderBase.java 8a7c06d
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveMetastoreAuthorizationProvider.java 0dab334
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PolicyProviderContainer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java 9b2e6cd
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java b66d188
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 48798d8
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 02ed7aa
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentAuthorizer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java 3eb0914
service/src/java/org/apache/hive/service/server/HiveServer2.java 661beb5
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 92d2e3f
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 6af2aa5
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 09f9bb1
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 264fdb9
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java ce7d286
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java b223920
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/HiveObjectPrivilegeBuilder.java d802e1a
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MDBPrivilege.java 3d8fa21
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MGlobalPrivilege.java 5b496e0
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionColumnPrivilege.java ab50a92
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionPrivilege.java 3193bc1
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTableColumnPrivilege.java ad7322f
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTablePrivilege.java 6460400
standalone-metastore/src/main/resources/package.jdo 2d2cb19
standalone-metastore/src/main/sql/derby/hive-schema-3.1.0.derby.sql PRE-CREATION
standalone-metastore/src/main/sql/derby/upgrade-3.0.0-to-3.1.0.derby.sql PRE-CREATION
standalone-metastore/src/main/sql/mssql/hive-schema-3.1.0.mssql.sql PRE-CREATION
standalone-metastore/src/main/sql/mssql/upgrade-3.0.0-to-3.1.0.mssql.sql PRE-CREATION
standalone-metastore/src/main/sql/mysql/hive-schema-3.1.0.mysql.sql PRE-CREATION
standalone-metastore/src/main/sql/mysql/upgrade-3.0.0-to-3.1.0.mysql.sql PRE-CREATION
standalone-metastore/src/main/sql/oracle/hive-schema-3.1.0.oracle.sql PRE-CREATION
standalone-metastore/src/main/sql/oracle/upgrade-3.0.0-to-3.1.0.oracle.sql PRE-CREATION
standalone-metastore/src/main/sql/postgres/hive-schema-3.1.0.postgres.sql PRE-CREATION
standalone-metastore/src/main/sql/postgres/upgrade-3.0.0-to-3.1.0.postgres.sql PRE-CREATION
standalone-metastore/src/main/thrift/hive_metastore.thrift 19d4433
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f6899be
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 98a85cc
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 7186add
Diff: https://reviews.apache.org/r/67102/diff/2/
Changes: https://reviews.apache.org/r/67102/diff/1-2/
Testing
-------
Thanks,
Daniel Dai
Re: Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer
work with information schema
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67102/#review203058
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PolicyProviderContainer.java
Lines 51 (patched)
<https://reviews.apache.org/r/67102/#comment285113>
naming convention would start with lower case - authorizationProviderPosition
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentAuthorizer.java
Lines 74 (patched)
<https://reviews.apache.org/r/67102/#comment285114>
can you add a comment about this fallback path for SBA ?
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java
Lines 65 (patched)
<https://reviews.apache.org/r/67102/#comment285136>
HIVE_AUTHORIZATION_ENABLED can be false , while metastore authorization (SBA) is enabled .
SBA doesn't use this flag. https://cwiki.apache.org/confluence/display/Hive/Storage+Based+Authorization+in+the+Metastore+Server#StorageBasedAuthorizationintheMetastoreServer-ConfigurationParametersforMetastoreSecurity
- Thejas Nair
On May 11, 2018, 9:55 p.m., Daniel Dai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67102/
> -----------------------------------------------------------
>
> (Updated May 11, 2018, 9:55 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See HIVE-19440
>
>
> Diffs
> -----
>
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/storagehandler/DummyHCatAuthProvider.java a53028f
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestHDFSPermissionPolicyProvider.java PRE-CREATION
> itests/util/src/main/java/org/apache/hadoop/hive/ql/security/DummyHiveMetastoreAuthorizationProvider.java 31e795c
> metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql d9606d8
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4611ce9
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HDFSPermissionPolicyProvider.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveAuthorizationProviderBase.java 8a7c06d
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveMetastoreAuthorizationProvider.java 0dab334
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PolicyProviderContainer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java 9b2e6cd
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java b66d188
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java 48798d8
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 02ed7aa
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentAuthorizer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java 3eb0914
> service/src/java/org/apache/hive/service/server/HiveServer2.java cf3edbf
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 3978b88
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 6af2aa5
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 09f9bb1
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java b43334b
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java ce7d286
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java b223920
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/client/builder/HiveObjectPrivilegeBuilder.java d802e1a
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MDBPrivilege.java 3d8fa21
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MGlobalPrivilege.java 5b496e0
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionColumnPrivilege.java ab50a92
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MPartitionPrivilege.java 3193bc1
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTableColumnPrivilege.java ad7322f
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTablePrivilege.java 6460400
> standalone-metastore/src/main/resources/package.jdo 2d2cb19
> standalone-metastore/src/main/sql/derby/hive-schema-3.0.0.derby.sql 8e09755
> standalone-metastore/src/main/sql/derby/upgrade-2.3.0-to-3.0.0.derby.sql 73bef36
> standalone-metastore/src/main/sql/mssql/hive-schema-3.0.0.mssql.sql 51df92c
> standalone-metastore/src/main/sql/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql a7232dd
> standalone-metastore/src/main/sql/mysql/hive-schema-3.0.0.mysql.sql 8e55e94
> standalone-metastore/src/main/sql/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 9a48346
> standalone-metastore/src/main/sql/oracle/hive-schema-3.0.0.oracle.sql 3a12e08
> standalone-metastore/src/main/sql/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 3be7e65
> standalone-metastore/src/main/sql/postgres/hive-schema-3.0.0.postgres.sql 0152f48
> standalone-metastore/src/main/sql/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql fed8a93
> standalone-metastore/src/main/thrift/hive_metastore.thrift 19d4433
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f6899be
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 98a85cc
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 7186add
>
>
> Diff: https://reviews.apache.org/r/67102/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Dai
>
>