You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by eolivelli <gi...@git.apache.org> on 2018/09/14 15:05:12 UTC
[GitHub] zookeeper pull request #626: ZOOKEEPER-3148 Add Kerberos tests for modern JD...
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/626
ZOOKEEPER-3148 Add Kerberos tests for modern JDKs
- This change is only for 3.4 branch, which MUST be compatible with JDK6
- Add Kerby and upgrade commons-io to 2.6, as needed by Kerby
- Copy Kerberos tests from branch-3.5 in a new package o.a.zookeeper.server.quorum.authnew
- Mark Kerberos tests to be executed only on JDK6 VMs
- Java version is done using system property, this is the safer way without introducing external libs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/zookeeper fix/34-kerby-jdk11
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/626.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #626
----
commit 1fd6282aa6c139b84c1c6bc60fb738819d8e7574
Author: Enrico Olivelli <eo...@...>
Date: 2018-09-13T18:04:41Z
ZOOKEEPER-3148 Add Kerberos tests for modern JDKs
- This change is only for 3.4 branch, which MUST be compatible with JDK6
- Add Kerby and upgrade commons-io to 2.6, as needed by Kerby
- Copy Kerberos tests from branch-3.5 in a new package o.a.zookeeper.server.quorum.authnew
- Mark Kerberos tests to be executed only on JDK6 VMs
- Java version is done using system property, this is the safer way without introducing external libs
----
---
[GitHub] zookeeper issue #626: ZOOKEEPER-3148 Add Kerberos tests for modern JDKs
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/626
Committed to 3.4
@eolivelli Please close this PR.
---
[GitHub] zookeeper issue #626: ZOOKEEPER-3148 Add Kerberos tests for modern JDKs
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/626
@anmolnar yes, I have just backported Kerby based tests from branch-3.5.
ApacheDS based tests will be only for 1.6 JDK.
Hopefully they will run only on CI.
---
[GitHub] zookeeper issue #626: ZOOKEEPER-3148 Add Kerberos tests for modern JDKs
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/626
@anmolnar @phunt @nkalmar
Green light from CI
Can you please take a look ?
So that we can archive this 'problem' and provide quick answers to users
---
[GitHub] zookeeper issue #626: ZOOKEEPER-3148 Add Kerberos tests for modern JDKs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/626
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2261/
---
[GitHub] zookeeper issue #626: ZOOKEEPER-3148 Add Kerberos tests for modern JDKs
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/626
Wow! This is huge. So basically we have a set of Kerberos tests for 1.6-only and another set for 1.7+, right?
That's the only way currently to keep 1.6 support. I think I'm fine with that.
---
[GitHub] zookeeper pull request #626: ZOOKEEPER-3148 Add Kerberos tests for modern JD...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli closed the pull request at:
https://github.com/apache/zookeeper/pull/626
---