You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/09/18 23:26:00 UTC

[jira] [Commented] (IMPALA-10171) Create query options for convert_legacy_hive_parquet_utc_timestamps and use_local_tz_for_unix_timestamp_conversions

    [ https://issues.apache.org/jira/browse/IMPALA-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198584#comment-17198584 ] 

ASF subversion and git services commented on IMPALA-10171:
----------------------------------------------------------

Commit 5dccf8024b17148e3736473d03426588f434af48 in impala's branch refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5dccf80 ]

IMPALA-10171: Create query options for local time related flags

convert_legacy_hive_parquet_utc_timestamps and
use_local_tz_for_unix_timestamp_conversions were controllable only by
flags until now. After this change the old flags are only used on the
Coordinator to set the defaults for the query options.

If default_query_options also sets these query options, it will
take precedence over the old flags.

Possible follow up work:
- the old flags could be deprecated, as default_query_options
  can be used to set this on a server level
- testing these functionalities no longer needs custom cluster
  tests - rewriting the existing tests could speed up test
  execution

Testing:
- expr-test was rewritten to use the query option instead of the flag
- extended the custom cluster tests for the old flags to also use the
  query options
- ran related tests

Change-Id: I5c4252d1c8f8e224c1d0e8234f09374bcc0c6f68
Reviewed-on: http://gerrit.cloudera.org:8080/16469
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Create query options for convert_legacy_hive_parquet_utc_timestamps and use_local_tz_for_unix_timestamp_conversions
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-10171
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10171
>             Project: IMPALA
>          Issue Type: Improvement
>            Reporter: Csaba Ringhofer
>            Priority: Major
>
> convert_legacy_hive_parquet_utc_timestamps and use_local_tz_for_unix_timestamp_conversions are flags that can be set on all coordinators and executors. Possible inconsistencies could be avoided by always using the flag's value on the coordinator, or adding a query options for these settings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org