[arrow-nanoarrow] branch main updated: fix: Resolve build warnings on Windows (#304)

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git


The following commit(s) were added to refs/heads/main by this push:
     new d4b6c67  fix: Resolve build warnings on Windows (#304)
d4b6c67 is described below

commit d4b6c6722dcadcffa3349443c97369805041f769
Author: Dewey Dunnington <de...@dunnington.ca>
AuthorDate: Mon Sep 25 17:17:33 2023 -0300

    fix: Resolve build warnings on Windows (#304)
---
 src/nanoarrow/array_test.cc  | 3 +--
 src/nanoarrow/buffer_test.cc | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/nanoarrow/array_test.cc b/src/nanoarrow/array_test.cc
index eb34243..6585957 100644
--- a/src/nanoarrow/array_test.cc
+++ b/src/nanoarrow/array_test.cc
@@ -1333,7 +1333,6 @@ TEST(ArrayTest, ArrayTestAppendToFixedSizeListArray) {
 TEST(ArrayTest, ArrayTestAppendToListArrayErrors) {
   struct ArrowArray array;
   struct ArrowSchema schema;
-  struct ArrowError error;
 
   ASSERT_EQ(ArrowSchemaInitFromType(&schema, NANOARROW_TYPE_LIST), NANOARROW_OK);
   ASSERT_EQ(ArrowSchemaSetType(schema.children[0], NANOARROW_TYPE_INT64), NANOARROW_OK);
@@ -1695,7 +1694,7 @@ TEST(ArrayTest, ArrayViewTestString) {
 
   // Check sequential offsets whose diff causes overflow
   offsets[1] = 2080374784;
-  offsets[2] = -2147483648;
+  offsets[2] = INT_MIN;
   EXPECT_EQ(ArrowArrayViewSetArray(&array_view, &array, &error), NANOARROW_OK);
   EXPECT_EQ(ArrowArrayViewValidate(&array_view, NANOARROW_VALIDATION_LEVEL_FULL, &error),
             EINVAL);
diff --git a/src/nanoarrow/buffer_test.cc b/src/nanoarrow/buffer_test.cc
index de8741c..141911f 100644
--- a/src/nanoarrow/buffer_test.cc
+++ b/src/nanoarrow/buffer_test.cc
@@ -294,8 +294,8 @@ void TestArrowBitmapUnpackUnsafe(const uint8_t* bitmap, std::vector<int8_t> expe
 TEST(BitmapTest, BitmapTestBitmapUnpack) {
   uint8_t bitmap[3];
   int8_t result[sizeof(bitmap) * 8];
+  int32_t result32[sizeof(result)];
   int64_t n_values = sizeof(result);
-  int32_t result32[n_values];
 
   // Basic test of a validity buffer that is all true
   memset(bitmap, 0xff, sizeof(bitmap));