[GitHub] [airflow] hussein-awala commented on a diff in pull request #30310: In `DockerOperator`, adding an attribute `tls_verify` to choose whether to validate certificate (#30309)

["hussein-awala (via GitHub)" <gi...@apache.org>]

hussein-awala commented on code in PR #30310:
URL: https://github.com/apache/airflow/pull/30310#discussion_r1155216890


##########
airflow/providers/docker/operators/docker.py:
##########
@@ -186,6 +187,7 @@ def __init__(
         tls_ca_cert: str | None = None,
         tls_client_cert: str | None = None,
         tls_client_key: str | None = None,
+        tls_verify: bool | None = None,

Review Comment:
   > How about setting the default value to True as it was?
   
   For now, the default value is None (equivalent to False), IMO it's better to use `False` as default value as it's now, WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org