You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by masaki-yamakawa <gi...@git.apache.org> on 2017/04/30 04:43:05 UTC
[GitHub] geode pull request #483: GEODE-2853: Change of locator list request interval
GitHub user masaki-yamakawa opened a pull request:
https://github.com/apache/geode/pull/483
GEODE-2853: Change of locator list request interval
If you connect to a Geode cluster using a locator from the client, the locator list request will be executed at regular intervals in the background thread. I want to tune this interval. I understand that this interval can be changed by the ping-interval of the Pool attribute. However, I think that ping-interval originally sets the ping interval for health check to the cache server. Therefore, it is not possible to change the locator list request interval without changing the health check interval to the cache server. So,I want to add a java system property that can change the locator list request interval.
The locator list request interval is determined by the following priority order.
1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL"
2. ping-interval of the Pool attribute
In addition, when changing this time, the background thread is activated only when this value is a positive value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaki-yamakawa/geode feature/GEODE-2853
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #483
----
commit f909d4fb7dcdf5dfc0f122663169324788fe5538
Author: masaki.yamakawa <ma...@ulsystems.co.jp>
Date: 2017-04-30T04:38:10Z
GEODE-2853: Change of locator list request interval
If you connect to a Geode cluster using a locator from the client, the
locator list request will be executed at regular intervals in the
background thread. I want to tune this interval. I understand that this
interval can be changed by the ping-interval of the Pool attribute.
However, I think that ping-interval originally sets the ping interval
for health check to the cache server. Therefore, it is not possible to
change the locator list request interval without changing the health
check interval to the cache server. So,I want to add a java system
property that can change the locator list request interval.
The locator list request interval is determined by the following
priority order.
1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL"
2. ping-interval of the Pool attribute
In addition, when changing this time, the background thread is activated
only when this value is a positive value.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #483: GEODE-2853: Change of locator list request interval
Posted by masaki-yamakawa <gi...@git.apache.org>.
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
Thanks for the suggestion. I fixed that.
@bschuchardt @kirklund
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #483: GEODE-2853: Change of locator list request interval
Posted by masaki-yamakawa <gi...@git.apache.org>.
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
I don't mind even if you don't complete by early next week. I would appreciate it if you can do it by the week after the next.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #483: GEODE-2853: Change of locator list request interval
Posted by masaki-yamakawa <gi...@git.apache.org>.
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
Thanks @bschuchardt for review. You are right, so delete the test added to AutoConnectionSourceDUnitTest and add it to AutoConnectionSourceImplJUnitTest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #483: GEODE-2853: Change of locator list request interval
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/483#discussion_r114611067
--- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorTestBase.java ---
@@ -289,6 +289,13 @@ public void run() throws Exception {
}
}
+ protected void startBridgeClient(final String group, final String host, final int port,
--- End diff --
Since this method is setting system properties I don't think it is appropriate to have it in LocatorTestBase. You should move it to AutoConnectionSourceDUnitTest and use the DistributedRestoreSystemProperties rule to ensure that the properties are cleaned up. To do that, add this to AutoConnectionSourceDUnitTest:
@Rule
public DistributedRestoreSystemProperties restoreSystemProperties =
new DistributedRestoreSystemProperties();
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #483: GEODE-2853: Change of locator list request interval
Posted by kohlmu-pivotal <gi...@git.apache.org>.
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/483#discussion_r116248082
--- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java ---
@@ -109,6 +110,7 @@ public void setUp() throws Exception {
@After
public void tearDown() {
+ System.clearProperty(DistributionConfig.GEMFIRE_PREFIX + "LOCATOR_UPDATE_INTERVAL");
--- End diff --
This can be replaced with
`@Rule
public final RestoreSystemProperties restoreSystemProperties = new RestoreSystemProperties();`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #483: GEODE-2853: Change of locator list request interval
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/483
I will merge this pull request to develop. I may not get it done until early next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #483: GEODE-2853: Change of locator list request interval
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/483#discussion_r114674582
--- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorTestBase.java ---
@@ -289,6 +289,13 @@ public void run() throws Exception {
}
}
+ protected void startBridgeClient(final String group, final String host, final int port,
--- End diff --
+1 to Bruce's suggestion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #483: GEODE-2853: Change of locator list request interval
Posted by masaki-yamakawa <gi...@git.apache.org>.
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
I moved the test added to AutoConnectionSourceDUnitTest to AutoConnectionSourceImplJUnitTest, and revert AutoConnectionSourceDUnitTest.
I tested by gradle precheckin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #483: GEODE-2853: Change of locator list request interval
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #483: GEODE-2853: Change of locator list request interval
Posted by masaki-yamakawa <gi...@git.apache.org>.
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
@kohlmu-pivotal Thank you for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #483: GEODE-2853: Change of locator list request interval
Posted by masaki-yamakawa <gi...@git.apache.org>.
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
Thanks @bschuchardt @kirklund for review.
Is this PR OK to merge?
If it is possible to merge, I do not have the merge permission, so I would appreciate if you could please merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---